-
Notifications
You must be signed in to change notification settings - Fork 2.9k
Fix 'default typecheck mode' #1054
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @T045TN1NJ4, thanks so much for helping improve the Roblox creator documentation! Our technical writing team will review your pull request soon. In the meantime, please ensure you've read through the README.md, contribution guidelines, and style recommendations.
vegorov-rbx
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change might have been appropriate before, but now it goes against what we have planned for Luau typechecking.
nocheck will not be the default. It's not even the default to people with non-strict by default Beta enabled or auto-enrolled.
Resolved by removing mention of default.
|
I opted to just remove mention of what's the default entirely, as it may adapt over time and become misleading if not updated frequently. This route simply states the options and lets scripters decide what to use. |
Changes
Updates the typechecking docs to appropriately reflect the default typechecking mode for scripts (currently
nocheckbut documented asnonstrict).Evidence [that the default mode is nocheck]
nonstrictas the default.nocheckandnonstrictwill show that [without enabling the Studio beta] scripts default tonocheck.nocheck.Additional Notes
The Luau docs do happen to say that
nonstrictis the default. This seems to be the case for everywhere that isn't ROBLOX Studio. I'm assuming that someone [understandably] copied the Luau docs, which [unfortunately] isn't accurate for Studio.