Skip to content

Conversation

@ishtar112
Copy link
Contributor

@ishtar112 ishtar112 commented Mar 19, 2025

Changes

Updates the typechecking docs to appropriately reflect the default typechecking mode for scripts (currently nocheck but documented as nonstrict).

Evidence [that the default mode is nocheck]

Additional Notes

The Luau docs do happen to say that nonstrict is the default. This seems to be the case for everywhere that isn't ROBLOX Studio. I'm assuming that someone [understandably] copied the Luau docs, which [unfortunately] isn't accurate for Studio.

@ishtar112 ishtar112 requested a review from a team as a code owner March 19, 2025 20:01
@github-actions github-actions bot added the engine guides Changes the Engine guides label Mar 19, 2025
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @T045TN1NJ4, thanks so much for helping improve the Roblox creator documentation! Our technical writing team will review your pull request soon. In the meantime, please ensure you've read through the README.md, contribution guidelines, and style recommendations.

@ishtar112 ishtar112 changed the title Update type-checking.md Fix 'default typecheck mode' Mar 19, 2025
Copy link

@vegorov-rbx vegorov-rbx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change might have been appropriate before, but now it goes against what we have planned for Luau typechecking.

nocheck will not be the default. It's not even the default to people with non-strict by default Beta enabled or auto-enrolled.

@IgnisRBX IgnisRBX dismissed vegorov-rbx’s stale review March 20, 2025 17:46

Resolved by removing mention of default.

@IgnisRBX
Copy link
Contributor

I opted to just remove mention of what's the default entirely, as it may adapt over time and become misleading if not updated frequently. This route simply states the options and lets scripters decide what to use.

@IgnisRBX IgnisRBX merged commit 8af5677 into Roblox:main Mar 20, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

engine guides Changes the Engine guides

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants