-
Notifications
You must be signed in to change notification settings - Fork 2.9k
Update RunService.yaml #1079
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update RunService.yaml #1079
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @ColRealPro, thanks so much for helping improve the Roblox creator documentation! Our technical writing team will review your pull request soon. In the meantime, please ensure you've read through the README.md, contribution guidelines, and style recommendations.
|
Hi @ColRealPro Could you please explain in more detail why changing it to "simulation step" is more accurate than "frame"? All of the other events for RunService are stated in "frame" terms, so curious why this should be an exception... |
|
Hi @IgnisRBX I think that simulation step makes more sense for this because unlike the other events in RunService, this one's deltaTime isn't actually based on the time since the last frame, but rather is always in increments of 1/240 (0.00416, 0.00833, 0.0125) since the physics engine does steps of 1/240, this also means that if your fps is above 240 that PreSimulation may not run every frame as the docs say Technically it's not actually the time since the last step exactly, maybe it should be clarified that it's usually in increments of 1/240? |
|
Hi again @ColRealPro , |
|
Hello again @IgnisRBX, I think these changes are great! LGTM |
|
Hi @ColRealPro , |

Changes
I have changed the description of the
DeltaTimeSimparam to correctly say it is the time since the last simulation step instead of the last frameChecks
By submitting your pull request for review, you agree to the following: