-
Notifications
You must be signed in to change notification settings - Fork 2.9k
Update task.yaml #1093
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update task.yaml #1093
Conversation
Thanks you have permission to code and add updates |
|
Hi @lack-of-gravity-jack,
I also made a bunch of small edits to fix minor grammar and un-linked APIs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
I noticed references to fastSpawn in task.spawn section. I personally didn't know what fast spawn was and after looking around a bit, it seems like a workaround to the legacy spawn()'s yielding behavior, to get a new thread to run instantaneously using bindables (this may be incorrect). I feel like this tidbit is unnecessarily confusing to leave in there now that there's been no reason to use this fastSpawn pattern for many years. Also, I don't believe the fastspawn pattern would even work anymore since events are deferred
the bit about task.spawn not being a replacement for legacy spawn can be clarified instead as
"Unlike the deprecated global spawn() function, this function resumes the accepted function/thread immediately"
|
Good call on researching the |
Changes
common misconception is that people think defer "defers" to a later frame
Checks
By submitting your pull request for review, you agree to the following: