-
Notifications
You must be signed in to change notification settings - Fork 2.9k
Create Clicxey #1188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
millerjaxx71-ai
wants to merge
260
commits into
Roblox:DefaultListenerLocation-description
from
millerjaxx71-ai:patch-1
Closed
Create Clicxey #1188
millerjaxx71-ai
wants to merge
260
commits into
Roblox:DefaultListenerLocation-description
from
millerjaxx71-ai:patch-1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## Changes This change fixes the incorrect url of ```www.authorize.roblox.com``` and changes it to ```authorize.roblox.com```. ## Checks By submitting your pull request for review, you agree to the following: - [x] This contribution was created in whole or in part by me, and I have the right to submit it under the terms of this repository's open source licenses. - [x] I understand and agree that this contribution and a record of it are public, maintained indefinitely, and may be redistributed under the terms of this repository's open source licenses. - [x] To the best of my knowledge, all proposed changes are accurate. Co-authored-by: IgnisRBX <[email protected]>
## Changes Updates the typechecking docs to appropriately reflect the default typechecking mode for scripts (currently `nocheck` but documented as `nonstrict`). ## Evidence [that the default mode is nocheck] - There is an open Studio beta to use `nonstrict` as the default. - Simply comparing the differences between how a script is typechecked in both `nocheck` and `nonstrict` will show that [without enabling the Studio beta] scripts default to `nocheck`. - [A member of the Luau team asserting that the default is `nocheck`.](https://discord.com/channels/385151591524597761/402843211707449354/1351995740292907008) ## Additional Notes [The Luau docs do happen to say that `nonstrict` is the default](https://luau.org/typecheck#type-inference-modes). This seems to be the case for everywhere that *isn't* ROBLOX Studio. I'm assuming that someone [understandably] copied the Luau docs, which [unfortunately] isn't accurate for Studio.
…be accessed from Roblox Studio (Roblox#1057) ## Changes Replaced "their are plans in the future" with "there are plans in the future" in the How to use Scale section. Also I fixed a misinformation stating that Lighting.Technology can be changed from Roblox Studio - it can't be even read from studio. ## Checks By submitting your pull request for review, you agree to the following: - [x] This contribution was created in whole or in part by me, and I have the right to submit it under the terms of this repository's open source licenses. - [x] I understand and agree that this contribution and a record of it are public, maintained indefinitely, and may be redistributed under the terms of this repository's open source licenses. - [x] To the best of my knowledge, all proposed changes are accurate. ---------
## Changes EnableDefaultVoice didn't explain what it does when its set to false on a game that uses the new audio API. ## Checks By submitting your pull request for review, you agree to the following: - [x] This contribution was created in whole or in part by me, and I have the right to submit it under the terms of this repository's open source licenses. - [x] I understand and agree that this contribution and a record of it are public, maintained indefinitely, and may be redistributed under the terms of this repository's open source licenses. - [x] To the best of my knowledge, all proposed changes are accurate.
## Changes The asset creation methods is currently only usable by plugins loaded in the LocalPlugin folder, this change marks that in the two relevant methods. ## Checks By submitting your pull request for review, you agree to the following: - [x] This contribution was created in whole or in part by me, and I have the right to submit it under the terms of this repository's open source licenses. - [x] I understand and agree that this contribution and a record of it are public, maintained indefinitely, and may be redistributed under the terms of this repository's open source licenses. - [x] To the best of my knowledge, all proposed changes are accurate. --------- Co-authored-by: IgnisRBX <[email protected]> Co-authored-by: Francis O'Brien <[email protected]>
## Changes This PR adds documentation for the Asset Delivery API to the Legacy overview page. The new section includes the base URL, authentication types, and available endpoints with their corresponding scopes. ## Checks By submitting your pull request for review, you agree to the following: - [X] This contribution was created in whole or in part by me, and I have the right to submit it under the terms of this repository's open source licenses. - [X] I understand and agree that this contribution and a record of it are public, maintained indefinitely, and may be redistributed under the terms of this repository's open source licenses. - [X] To the best of my knowledge, all proposed changes are accurate.
…#1055) ## Changes This PR audits every usage of `Lua` on the Creator Docs site to ensure that we are referring to the correct language throughout our documentation. In almost all cases, we mean to refer to the scripting language actually available on Roblox, which has been named Luau since 2020. I think five years is long enough for us to finally correct this issue. I've left in tact all references to Lua Learning, which of course just _has_ the name with Lua for historical reasons, and preserved any references that otherwise actually mean to refer to Lua (such as mentions of the idiomatic pattern for classes in Lua, or references to differences between Luau and Lua). The Education folks in particular may want to add a little bit of context to explain that (at least as far as I know) most of the things they're teaching apply just as well to Lua as to Luau, but especially since all of those articles are describing programming _in Roblox Studio_, I think it's important to be explicit that the language they're programming in is Luau. ## Checks By submitting your pull request for review, you agree to the following: - [X] This contribution was created in whole or in part by me, and I have the right to submit it under the terms of this repository's open source licenses. - [X] I understand and agree that this contribution and a record of it are public, maintained indefinitely, and may be redistributed under the terms of this repository's open source licenses. - [X] To the best of my knowledge, all proposed changes are accurate. --------- Co-authored-by: IgnisRBX <[email protected]>
…ditableImage:ReadPixels and rewrote select descriptions accordingly. (Roblox#1063) ## Changes <!-- Please summarize your changes. --> Removed references to `EditableImage:WritePixels` and `EditableImage:ReadPixels` from the documentation of `EditableImage:WritePixelsBuffer` and `EditableImage:ReadPixelsBuffer`, as these methods were removed from the API. This update ensures that references to non-existent methods do not mislead developers. Additionally, it improves documentation clarity by updating previously outdated descriptions on references to outdated methods. <!-- Please link to any applicable information (forum posts, bug reports, etc.). --> Devforum update post detailing the removal of `EditableImage:WritePixels` and `EditableImage:ReadPixels` among other things. https://devforum.roblox.com/t/studio-beta-major-updates-to-in-experience-mesh-image-apis/3225681 ## Checks By submitting your pull request for review, you agree to the following: - [x] This contribution was created in whole or in part by me, and I have the right to submit it under the terms of this repository's open source licenses. - [x] I understand and agree that this contribution and a record of it are public, maintained indefinitely, and may be redistributed under the terms of this repository's open source licenses. - [x] To the best of my knowledge, all proposed changes are accurate. ---------
…ox#1064) ## Changes This pull request corrects a typo in the code where "ServerScriptStorage" was mistakenly used instead of "ServerScriptService". Source: https://create.roblox.com/docs/chat/examples/group-chat-tags ## Checks By submitting your pull request for review, you agree to the following: - [X] This contribution was created in whole or in part by me, and I have the right to submit it under the terms of this repository's open source licenses. - [X] I understand and agree that this contribution and a record of it are public, maintained indefinitely, and may be redistributed under the terms of this repository's open source licenses. - [X] To the best of my knowledge, all proposed changes are accurate.
## Changes Changes "Explorer" to a hyperlink to the explorer documentation. This is important for those unfamiliar with Roblox terminology or who do not know what the Explorer looks like. N/A ## Checks By submitting your pull request for review, you agree to the following: - [x] This contribution was created in whole or in part by me, and I have the right to submit it under the terms of this repository's open source licenses. - [x] I understand and agree that this contribution and a record of it are public, maintained indefinitely, and may be redistributed under the terms of this repository's open source licenses. - [ ] To the best of my knowledge, all proposed changes are accurate. --------- Co-authored-by: IgnisRBX <[email protected]>
## Changes Added alt="" to some images to ensure accessibility or if the user has slow internet. Changed wording from MaterialVariant being a child of the mesh part, which is totally incorrect, MaterialVariant's only work in MaterialService and must be set in the mesh's MaterialVariant property otherwise it does not work. Changed wording how to add a SurfaceApperance or MaterialVariant to reflect how it works ^. If you require more information about these changes please leave a comment and I'll be happy to awnser any questions. N/A ## Checks By submitting your pull request for review, you agree to the following: - [x] This contribution was created in whole or in part by me, and I have the right to submit it under the terms of this repository's open source licenses. - [x] I understand and agree that this contribution and a record of it are public, maintained indefinitely, and may be redistributed under the terms of this repository's open source licenses. - [x] To the best of my knowledge, all proposed changes are accurate. --------- Co-authored-by: IgnisRBX <[email protected]>
## Changes Fixes instances of “Roblox” that are misspelt as “Robox”, that is all! ## Checks By submitting your pull request for review, you agree to the following: - [x] This contribution was created in whole or in part by me, and I have the right to submit it under the terms of this repository's open source licenses. - [x] I understand and agree that this contribution and a record of it are public, maintained indefinitely, and may be redistributed under the terms of this repository's open source licenses. - [x] To the best of my knowledge, all proposed changes are accurate.
## Changes Fixed typo 'would allows' to 'would allow' Co-authored-by: Andrew Etter <[email protected]>
Removes the incorrect statement that Players:GetCharacterAppearanceInfoAsync ignores gear. Testing shows that gear is included in the returned assets table. This change makes the documentation accurate. ## Changes <img width="626" height="416" alt="image" src="https://github.com/user-attachments/assets/edb39c96-65ca-40a5-b7c8-57a43982dd60" /> ## Checks By submitting your pull request for review, you agree to the following: - [x] This contribution was created in whole or in part by me, and I have the right to submit it under the terms of this repository's open source licenses. - [x] I understand and agree that this contribution and a record of it are public, maintained indefinitely, and may be redistributed under the terms of this repository's open source licenses. - [x] To the best of my knowledge, all proposed changes are accurate. Co-authored-by: Andrew Etter <[email protected]>
## Changes Clarity/typo fixes. ## Checks By submitting your pull request for review, you agree to the following: - [x] This contribution was created in whole or in part by me, and I have the right to submit it under the terms of this repository's open source licenses. - [x] I understand and agree that this contribution and a record of it are public, maintained indefinitely, and may be redistributed under the terms of this repository's open source licenses. - [x] To the best of my knowledge, all proposed changes are accurate. --------- Co-authored-by: Andrew Etter <[email protected]> Co-authored-by: julia <[email protected]>
## Changes Replaced occurrences of "game" with "experience" and "friends" with "connections" to match current Roblox terminology ## Checks By submitting your pull request for review, you agree to the following: - [ ] This contribution was created in whole or in part by me, and I have the right to submit it under the terms of this repository's open source licenses. - [ ] I understand and agree that this contribution and a record of it are public, maintained indefinitely, and may be redistributed under the terms of this repository's open source licenses. - [ ] To the best of my knowledge, all proposed changes are accurate. --------- Co-authored-by: Andrew Etter <[email protected]>
## Changes Replaced all mentions of “Friends” with “Connections” to stay consistent with the new naming used on the Roblox platform. ## Checks By submitting your pull request for review, you agree to the following: - [ ] This contribution was created in whole or in part by me, and I have the right to submit it under the terms of this repository's open source licenses. - [ ] I understand and agree that this contribution and a record of it are public, maintained indefinitely, and may be redistributed under the terms of this repository's open source licenses. - [ ] To the best of my knowledge, all proposed changes are accurate. Co-authored-by: Andrew Etter <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @millerjaxx71-ai, thanks so much for helping improve the Roblox creator documentation! Our technical writing team will review your pull request soon. In the meantime, please ensure you've read through the README.md, contribution guidelines, and style recommendations.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Checks
By submitting your pull request for review, you agree to the following: