Skip to content

Conversation

@Lucatacos
Copy link
Contributor

Changes

Reverting my change (#984) because the original example is clearer and handles all cases better. It properly sets collision groups for parts added after the character spawns, which my version didn’t cover. This makes the official documentation more complete and easier to understand.

Regarding performance, the difference is minimal for most use cases, but the original version is safer as it handles dynamic parts correctly without impacting performance noticeably

Checks

By submitting your pull request for review, you agree to the following:

  • This contribution was created in whole or in part by me, and I have the right to submit it under the terms of this repository's open source licenses.
  • I understand and agree that this contribution and a record of it are public, maintained indefinitely, and may be redistributed under the terms of this repository's open source licenses.
  • To the best of my knowledge, all proposed changes are accurate.

…mple

Reverting my change (Roblox#984) because the original example is clearer and handles all cases better.
It properly sets collision groups for parts added after the character spawns, which my version didn’t cover.
This makes the official documentation more complete and easier to understand.

Regarding performance, the difference is minimal for most use cases, but the original version is safer as it handles dynamic parts correctly without impacting performance noticeably.
@Lucatacos Lucatacos requested a review from a team as a code owner August 8, 2025 10:19
@github-actions github-actions bot added the engine guides Changes the Engine guides label Aug 8, 2025
@Lucatacos Lucatacos closed this Aug 8, 2025
@Lucatacos Lucatacos deleted the patch-7 branch August 8, 2025 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

engine guides Changes the Engine guides

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant