Skip to content

Conversation

@ProtoValence
Copy link
Contributor

@ProtoValence ProtoValence commented Aug 14, 2025

Why are the changes being made?

Changes

In order to follow up with this DevForum bug report, I'm updating documentation surround UIPageLayout to be more descriptive. More specifically, I've updated the description for the PageEnter and PageLeave events, to state that they are only used to determine whether a page has become visible on the screen.

It also provides an alternative method for determining when a page has changed (which is likely to apply to a lot of, if not most developers.

Checks

By submitting your pull request for review, you agree to the following:

  • This contribution was created in whole or in part by me, and I have the right to submit it under the terms of this repository's open source licenses.
  • I understand and agree that this contribution and a record of it are public, maintained indefinitely, and may be redistributed under the terms of this repository's open source licenses.
  • To the best of my knowledge, all proposed changes are accurate.

What changes are being made?

  • Clarifies UIPageLayout.PageEnter and PageLeave event docs in UIPageLayout.yaml, explaining visibility, rendering, and alternatives for page change detection.

  • AI-assisted summary reviewed and verified by author

@ProtoValence ProtoValence requested a review from a team as a code owner August 14, 2025 17:35
@github-actions github-actions bot added engine reference Changes the Engine API Reference documentation changes requested This pull request has changes requested prior to merging labels Aug 14, 2025
@IgnisRBX IgnisRBX marked this pull request as draft August 14, 2025 21:45
@jaycewatts321-ui
Copy link

Jump.consel.cmds

@syafiqlkram572-lgtm
Copy link

1 similar comment
@syafiqlkram572-lgtm
Copy link

@levibeerens0-afk
Copy link

Hello

@GEELE305
Copy link

Pls let me know how to create a game on roblox on mobile

@github-actions
Copy link

This pull request has been inactive for 14 days. If there's no activity in the next 7 days, it will be automatically closed. To keep it open, please comment or push new commits. Alternatively, add the label do-not-close to exempt it from auto-closing. 🫡 🙏

@github-actions github-actions bot added the stale label Sep 11, 2025
@github-actions
Copy link

This pull request has been inactive for 21 days and is now being closed automatically. If it's still relevant, feel free to reopen it or start a new one. To prevent this in the future, you can add the do-not-close label to exempt it from automatic closure. Thank you! 🫡 🙏

@github-actions github-actions bot closed this Sep 18, 2025
@github-actions github-actions bot deleted the patch/UIPageLayout-PageEnter-PageLeave branch September 18, 2025 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changes requested This pull request has changes requested prior to merging engine reference Changes the Engine API Reference documentation stale

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants