Skip to content

add descriptions for SpectrumEnabled, Bypass, and GetConnectedWires #848

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 18 commits into from
Sep 30, 2024
Merged

add descriptions for SpectrumEnabled, Bypass, and GetConnectedWires #848

merged 18 commits into from
Sep 30, 2024

Conversation

@rbxphogen
Copy link
Contributor

@rbxphogen rbxphogen commented Sep 30, 2024 •
edited
Loading

Changes

add descriptions for AudioAnalyzer.SpectrumEnabled, Audio*.Bypass, and Audio*:GetConnectedWires

Checks

By submitting your pull request for review, you agree to the following:

  • This contribution was created in whole or in part by me, and I have the right to submit it under the terms of this repository's open source licenses.
  • I understand and agree that this contribution and a record of it are public, maintained indefinitely, and may be redistributed under the terms of this repository's open source licenses.
  • To the best of my knowledge, all proposed changes are accurate.

@github-actions github-actions bot added the engine reference Changes the Engine API Reference documentation label Sep 30, 2024
@rbxphogen rbxphogen marked this pull request as ready for review September 30, 2024 18:09
@rbxphogen rbxphogen requested a review from a team as a code owner September 30, 2024 18:09
dandrettarbx
dandrettarbx previously approved these changes Sep 30, 2024
View reviewed changes
@dandrettarbx
Update content/en-us/reference/engine/classes/AudioAnalyzer.yaml
a275f40
@dandrettarbx
Update content/en-us/reference/engine/classes/AudioAnalyzer.yaml
7c478ec
@dandrettarbx
Update content/en-us/reference/engine/classes/AudioAnalyzer.yaml
265055c
@dandrettarbx
Update content/en-us/reference/engine/classes/AudioAnalyzer.yaml
494a291
@dandrettarbx
Update content/en-us/reference/engine/classes/AudioPitchShifter.yaml
83ab454
@dandrettarbx
Update content/en-us/reference/engine/classes/AudioPlayer.yaml
c3e5697
@dandrettarbx
Update content/en-us/reference/engine/classes/AudioReverb.yaml
f13c3d6
@dandrettarbx
Update content/en-us/reference/engine/classes/AudioReverb.yaml
f4ad893
@dandrettarbx
Update content/en-us/reference/engine/classes/AudioReverb.yaml
f36dc8f
@dandrettarbx
Update content/en-us/reference/engine/classes/AudioChorus.yaml
6bfbae9
@dandrettarbx
Update content/en-us/reference/engine/classes/AudioChorus.yaml
12c7ec2
@dandrettarbx
Update content/en-us/reference/engine/classes/AudioChorus.yaml
0d1dd22
@dandrettarbx
Update content/en-us/reference/engine/classes/AudioCompressor.yaml
5214896
@dandrettarbx
Update content/en-us/reference/engine/classes/AudioCompressor.yaml
44c4158
@dandrettarbx
Apply suggestions from code review
3a94d3e
@dandrettarbx
Merge branch 'main' into update/audio-bypass-and-connected-wires
357854b
@dandrettarbx dandrettarbx merged commit 907ecb9 into main Sep 30, 2024
3 checks passed
@dandrettarbx dandrettarbx deleted the update/audio-bypass-and-connected-wires branch September 30, 2024 22:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@matthewzhang-rbx matthewzhang-rbx Awaiting requested review from matthewzhang-rbx

1 more reviewer

@dandrettarbx dandrettarbx dandrettarbx approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

engine reference Changes the Engine API Reference documentation

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@rbxphogen @dandrettarbx