Skip to content

Update AudioApiRollout.yaml #867

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Oct 18, 2024
Merged

Update AudioApiRollout.yaml #867

merged 6 commits into from
Oct 18, 2024

Conversation

@rbxphogen
Copy link
Contributor

@rbxphogen rbxphogen commented Oct 17, 2024 •
edited
Loading

Changes

Adds a description for the AudioApiRollout enum

Checks

By submitting your pull request for review, you agree to the following:

  • This contribution was created in whole or in part by me, and I have the right to submit it under the terms of this repository's open source licenses.
  • I understand and agree that this contribution and a record of it are public, maintained indefinitely, and may be redistributed under the terms of this repository's open source licenses.
  • To the best of my knowledge, all proposed changes are accurate.

@github-actions github-actions bot added the engine reference Changes the Engine API Reference documentation label Oct 17, 2024
matthewzhang-rbx
matthewzhang-rbx reviewed Oct 17, 2024
View reviewed changes
matthewzhang-rbx
matthewzhang-rbx reviewed Oct 18, 2024
View reviewed changes
fumminger
fumminger previously approved these changes Oct 18, 2024
View reviewed changes
@rbxphogen rbxphogen marked this pull request as ready for review October 18, 2024 16:50
@rbxphogen rbxphogen requested a review from a team as a code owner October 18, 2024 16:50
matthewzhang-rbx
matthewzhang-rbx previously approved these changes Oct 18, 2024
View reviewed changes
Copy link
Contributor

@matthewzhang-rbx matthewzhang-rbx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

IgnisRBX
IgnisRBX reviewed Oct 18, 2024
View reviewed changes
IgnisRBX
IgnisRBX reviewed Oct 18, 2024
View reviewed changes
IgnisRBX
IgnisRBX reviewed Oct 18, 2024
View reviewed changes
IgnisRBX
IgnisRBX reviewed Oct 18, 2024
View reviewed changes
IgnisRBX
IgnisRBX reviewed Oct 18, 2024
View reviewed changes
@IgnisRBX IgnisRBX merged commit 96268bb into main Oct 18, 2024
3 checks passed
@IgnisRBX IgnisRBX deleted the describe-AudioApiRollout branch October 18, 2024 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@IgnisRBX IgnisRBX IgnisRBX approved these changes

@fumminger fumminger fumminger left review comments

@matthewzhang-rbx matthewzhang-rbx matthewzhang-rbx left review comments

@sofiaconmorales sofiaconmorales Awaiting requested review from sofiaconmorales

Assignees

No one assigned

Labels

engine reference Changes the Engine API Reference documentation

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@rbxphogen @fumminger @IgnisRBX @matthewzhang-rbx