Skip to content

Conversation

@Ramdoys
Copy link

@Ramdoys Ramdoys commented Oct 30, 2024

Changes

Made some typo fixes for micro profiler tags, as well as adding the full sequence to some of them.

Checks

By submitting your pull request for review, you agree to the following:

  • This contribution was created in whole or in part by me, and I have the right to submit it under the terms of this repository's open source licenses.
  • I understand and agree that this contribution and a record of it are public, maintained indefinitely, and may be redistributed under the terms of this repository's open source licenses.
  • To the best of my knowledge, all proposed changes are accurate.

@Ramdoys Ramdoys requested a review from a team as a code owner October 30, 2024 23:44
@github-actions github-actions bot added the studio Changes the Studio content label Oct 30, 2024
@Rajihr2
Copy link

Rajihr2 commented Oct 31, 2024

Hi

@Ramdoys
Copy link
Author

Ramdoys commented Nov 1, 2024

@IgnisRBX Hey, I don't know if you have any control over this, but do you know if there is a possibility of better documentation on these tags? I could add more of course, but I wouldn't know what they do internally. Seems more like a Roblox Staff oriented thing.

@aetter aetter merged commit 149bdb3 into Roblox:main Nov 1, 2024
3 checks passed
@aetter
Copy link
Contributor

aetter commented Nov 1, 2024

Hey @Ramdoys, this looks great, thanks a bunch. We're always happy to add to the list, but we're trying to be selective about it since so there are a) so many b) many are tiny and c) many aren't actionable. Are there any in particular that you'd like to see?

@Ramdoys Ramdoys deleted the tag-table-patch-1 branch November 1, 2024 23:29
@Ramdoys
Copy link
Author

Ramdoys commented Nov 1, 2024

Hey @Ramdoys, this looks great, thanks a bunch. We're always happy to add to the list, but we're trying to be selective about it since so there are a) so many b) many are tiny and c) many aren't actionable. Are there any in particular that you'd like to see?

@aetter Yeah, it totally makes sense for them to not be all documented and that some don't have a major impact or can't be acted upon. As for ones I'd like to see, the following have definitely been ones I've been curious about:

  • Prepare/UpdatePrepare/updateDynamicParts
  • Prepare/UpdatePrepare/processPendingParts
  • RenderJob/TransferControlToRenderThread/WaitForRenderThread
  • Simulation/physicsSteppedTotal/physicsStepped/frameStep ( - just in general, it has a ton of tags under it usually)
  • Perform/Scene/UpdateView

Thanks!

@aetter
Copy link
Contributor

aetter commented Nov 4, 2024

Hey @Ramdoys, this looks great, thanks a bunch. We're always happy to add to the list, but we're trying to be selective about it since so there are a) so many b) many are tiny and c) many aren't actionable. Are there any in particular that you'd like to see?

@aetter Yeah, it totally makes sense for them to not be all documented and that some don't have a major impact or can't be acted upon. As for ones I'd like to see, the following have definitely been ones I've been curious about:

  • Prepare/UpdatePrepare/updateDynamicParts
  • Prepare/UpdatePrepare/processPendingParts
  • RenderJob/TransferControlToRenderThread/WaitForRenderThread
  • Simulation/physicsSteppedTotal/physicsStepped/frameStep ( - just in general, it has a ton of tags under it usually)
  • Perform/Scene/UpdateView

Thanks!

Huge thanks, I've reported an (internal) bug on myself and will check these out in the coming weeks.

Copy link

@CEO-jun CEO-jun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ramdoys:tag-table-patch-1

@CEO-jun
Copy link

CEO-jun commented Nov 5, 2024

CEO-jun

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

studio Changes the Studio content

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants