Skip to content

Conversation

@CadeusTheGreat
Copy link
Contributor

Changes

The current documentation regularly reference different ways of getting workspace. This PR simplifies all the references of getting workspace to accessing the global variable workspace. The aim of this is to reduce lines of code in examples by not needing to store an extra variable which also hopefully simplifies the code for new learners.

Checks

By submitting your pull request for review, you agree to the following:

  • This contribution was created in whole or in part by me, and I have the right to submit it under the terms of this repository's open source licenses.
  • I understand and agree that this contribution and a record of it are public, maintained indefinitely, and may be redistributed under the terms of this repository's open source licenses.
  • To the best of my knowledge, all proposed changes are accurate.

@CadeusTheGreat CadeusTheGreat requested a review from a team as a code owner December 21, 2024 13:12
@github-actions github-actions bot added engine guides Changes the Engine guides engine reference Changes the Engine API Reference documentation studio Changes the Studio content tutorials Changes the tutorials labels Dec 21, 2024
@github-actions
Copy link

github-actions bot commented Jan 4, 2025

This pull request has been inactive for 14 days. If it remains inactive for another 7 days, it will close. Please update or comment on this pull request to keep it open. 🙏

@github-actions github-actions bot added the stale label Jan 4, 2025
@CadeusTheGreat
Copy link
Contributor Author

Waiting for review...

@edeppe
Copy link

edeppe commented Jan 6, 2025

thanks for the contribution! game:GetService("Workspace") is the preferred method of accessing workspace, as it provides consistency with other services

@github-actions github-actions bot removed the stale label Jan 6, 2025
@CadeusTheGreat
Copy link
Contributor Author

thanks for the contribution! game:GetService("Workspace") is the preferred method of accessing workspace, as it provides consistency with other services

In that case I will raise a new PR to be flipped and change all workspace references to :GetService.

@CadeusTheGreat CadeusTheGreat deleted the Simplify-Workspace-Reference branch January 27, 2025 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

engine guides Changes the Engine guides engine reference Changes the Engine API Reference documentation studio Changes the Studio content tutorials Changes the tutorials

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants