Skip to content

General Iteration #2 #974

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jan 13, 2025
Merged

General Iteration #2 #974

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
551935c
Migration to general iteration
CadeusTheGreat Jan 7, 2025
f8c64d6
Merge branch 'main' into General-Iteration-#2
CadeusTheGreat Jan 9, 2025
d75098e
Merge branch 'main' into General-Iteration-#2
CadeusTheGreat Jan 11, 2025
26eb132
Apply suggestions from code review
IgnisRBX Jan 13, 2025
c6d0d4d
Merge branch 'main' into General-Iteration-#2
IgnisRBX Jan 13, 2025
e8f10e4
Update transferring-animations.md
IgnisRBX Jan 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions content/en-us/projects/transferring-animations.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,9 +24,11 @@ If your animations are stored as Animation instances under pre-prepared Characte
1. In Roblox Studio, run the following script. Studio outputs the result as a single long string.

```lua
local Workspace = game:GetService("Workspace")

local ANIMSTRING = ""

for _, character in pairs(workspace:GetChildren()) do
for _, character in Workspace:GetChildren() do
if not character:IsA("Model") then
continue
end
Expand All @@ -36,7 +38,7 @@ for _, character in pairs(workspace:GetChildren()) do
continue
end

for _, animation in pairs(animations:GetChildren()) do
for _, animation in animations:GetChildren() do
local animationId = string.match(animation.AnimationId, "%d+")
if animationId then
ANIMSTRING ..= (animationId .. " " .. character.Name .. "_" .. string.gsub(animation.Name, " ", "_") .. "\n")
Expand Down Expand Up @@ -119,7 +121,7 @@ local function convertFileToAnimationMap(animFileText: string)
local NEW_ANIMATION_MAP = ""

local lines = string.split(animFileText, "\n")
for _, line in pairs(lines) do
for _, line in lines do
local components = string.split(line, " ")
if #components ~= 2 then
continue
Expand Down
8 changes: 4 additions & 4 deletions content/en-us/resources/feature-packages/bundles.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,7 @@ end

local function initializePurchaseHandlers()
local bundles = Bundles.getBundles()
for bundleId, bundle in pairs(bundles) do
for bundleId, bundle in bundles do
-- Bundle is not associated with a developer product if it does not have marketplace price type
if not bundle or bundle.pricing.priceType ~= "Marketplace" then
continue
Expand All @@ -133,7 +133,7 @@ local function initializePurchaseHandlers()
end

-- If you have any in-experience currencies that you are using for bundles, set the handler here
for currencyId, _ in pairs(Currencies) do
for currencyId, _ in Currencies do
Bundles.setInExperiencePurchaseHandler(currencyId, awardInExperiencePurchase)
end
end
Expand Down Expand Up @@ -286,7 +286,7 @@ You mainly need to hook up four things once dragging the **Bundles** feature pac

local function initializePurchaseHandlers()
local bundles = Bundles.getBundles()
for bundleId, bundle in pairs(bundles) do
for bundleId, bundle in bundles do
-- Bundle is not associated with a developer product if it does not have marketplace price type
if not bundle or bundle.pricing.priceType ~= "Marketplace" then
continue
Expand All @@ -297,7 +297,7 @@ You mainly need to hook up four things once dragging the **Bundles** feature pac
end

-- If you have any in-experience currencies that you are using for bundles, set the handler here
for currencyId, _ in pairs(Currencies) do
for currencyId, _ in Currencies do
Bundles.setInExperiencePurchaseHandler(currencyId, awardInExperiencePurchase)
end
end
Expand Down
Loading