Skip to content

Conversation

@joritochip
Copy link

Changes

Fixes a small typo and adds a missing parameter description to ChangeHistoryService.OnRecordingFinished

Checks

By submitting your pull request for review, you agree to the following:

  • This contribution was created in whole or in part by me, and I have the right to submit it under the terms of this repository's open source licenses.
  • I understand and agree that this contribution and a record of it are public, maintained indefinitely, and may be redistributed under the terms of this repository's open source licenses.
  • To the best of my knowledge, all proposed changes are accurate.

@joritochip joritochip requested a review from a team as a code owner January 11, 2025 07:46
@github-actions github-actions bot added the engine reference Changes the Engine API Reference documentation label Jan 11, 2025
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @joritochip, thanks so much for helping improve the Roblox creator documentation! Our technical writing team will review your pull request soon. In the meantime, please ensure you've read through the README.md, contribution guidelines, and style recommendations.

@github-actions github-actions bot added the changes requested This pull request has changes requested prior to merging label Jan 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only the following fields are editable: summary, description, deprecation_message. Other fields are automatically overwritten if edited. Please undo changes to the following fields:

  • events.0.parameters.3.name

⛔️ This change is a requirement. Please fix it before merging.

@IgnisRBX
Copy link
Contributor

Thanks for flagging this! Fixes of this type must be done in the source, which I've filed an internal request for. So, I'm closing your pull request here, but the issue will be resolved and I appreciate you calling attention to it. :)

@IgnisRBX IgnisRBX closed this Jan 16, 2025
@joritochip joritochip deleted the patch-1 branch January 19, 2025 06:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changes requested This pull request has changes requested prior to merging engine reference Changes the Engine API Reference documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants