Conversation
rhololkeolke
force-pushed
the
apriltags
branch
from
2750b5b to
3cf4886
Compare
|
Can we merge this in before master diverges too much? Other than it being a bit slow for high res images, everything seems to work for those that have tried it. And the speed-ups for high res images can be merged in a different request. |
rhololkeolke
force-pushed
the
apriltags
branch
from
4c944c3 to
46a7c1a
Compare
g3force
left a comment
g3force
left a comment
There was a problem hiding this comment.
Found some minor issues.
I'd like to have an automatic build with circleci to verify that everything builds fine with april tags from scratch. I can have a look at this.
There are some unrelated reformattings that bloads up the diff a bit, but it looks ok so far.
| team=global_team_selector_blue->getSelectedTeam(); | ||
| num_robots=global_team_selector_blue->getNumberRobots(); | ||
| detection_frame->clear_robots_blue(); | ||
| // detection_frame->clear_robots_blue(); |
There was a problem hiding this comment.
Why is this commented out? Can this be removed safely?
| robot_detection = detection_frame->add_robots_yellow(); | ||
| } | ||
| robot_detection->set_confidence( | ||
| det->decision_margin); // TODO(dschwab): What value should I put here? |
There was a problem hiding this comment.
is this still a TODO? Can this be resolved?
| color_id_team=team_color_id; | ||
| _max_robots=max_robots; | ||
| robots->Clear(); | ||
| // robots->Clear(); |
There was a problem hiding this comment.
same here: Can this be removed?
|
Automatic build for apriltag added to circleci config. It checks out the master branch of the apriltag library, so the build is not reproducible, but we will find issues with updates in the apriltag lib earlier. |
Don't call updateFieldLinesAndArcs in constructor Change Field Lines/Arcs Update button to read "Use Defaults"
Using homography and camera params image2field to detect apriltag orientation
rhololkeolke
force-pushed
the
apriltags
branch
from
7f3e8d6 to
a6b3787
Compare
|
The updated README.md should explicity say the april tags repo needs to be cloned and installed. Also I had to update my LD_LIBRARY_PATH env variable to include the path where the libapriltag.so files were installed, might be worth mentioning in the docs as well. Descriptions of the different AprilTag params I feel should also be added. |
3 participants
Adds a new optional apriltag robot detector plugin. See the README updates for more information about how to compile, run, and configure this detector.