Skip to content

Conversation

@keshav0479
Copy link
Contributor

What does this PR do?

Fixes #1382

This PR implements the frontend UI for setting routing_budget_ppm when claiming rewards.

Changes

  • Added a Routing Budget (PPM) input field to the Claim Rewards dialog.
  • Updated Robot.model.ts to pass the routing_budget_ppm parameter to the backend API.
  • Users can now specify a routing budget (default 1000 PPM) instead of relying on the backend default.
Screenshot From 2026-01-13 19-27-05

Context

This completes the feature introduced in #2038 (which added backend support) by providing the necessary UI in the frontend.

Verification

  • Tested locally(mock): The input field appears correctly and passes the value to the API.

Checklist before merging

  • Install pre-commit and initialize it: pip install pre-commit, then pre-commit install. Pre-commit installs git hooks that automatically check the codebase. If pre-commit fails when you commit your changes, please fix the problems it points out.

@KoalaSat
Copy link
Member

@keshav0479 can you do something with that "Claim" button, it already looked ugly before, it would be great if we make it look nicer now that we are touching

@keshav0479
Copy link
Contributor Author

you are totally right, it does need some love, i'll make sure it looks crisp and aligns better with the UI. Working on it

@keshav0479
Copy link
Contributor Author

Screenshot From 2026-01-16 00-09-36 Screenshot From 2026-01-16 00-09-51 Screenshot From 2026-01-16 00-18-37

How about this ? Let me know if you'd like any tweaks.

@KoalaSat
Copy link
Member

@keshav0479 awesome stuff

@KoalaSat
Copy link
Member

@keshav0479 seems like there are some 500 codes from the backend, we are checking, but this PR looks great 👍 in the mid time, do you think it's possible to keep the trophy icon after displaying the form? just to keep consistency.

I'll merge after we figure out what's wrong in backend.

@keshav0479
Copy link
Contributor Author

Done! trophy icon now stays visible in the expanded form
Screenshot From 2026-01-16 19-10-59

@keshav0479
Copy link
Contributor Author

@keshav0479 seems like there are some 500 codes from the backend, we are checking, but this PR looks great 👍 in the mid time, do you think it's possible to keep the trophy icon after displaying the form? just to keep consistency.

I'll merge after we figure out what's wrong in backend.

Regarding the 500 errors - I reviewed the code flow and confirmed my changes are purely UI/layout, so the API calls remain unchanged also the routing_budget_ppm was already supported since #2038. Happy to help dig into backend logs if you'd like an extra pair of eyes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Claiming rewards does not support routing_budget_ppm

2 participants