Skip to content

Conversation

@GautamSingh0310
Copy link

What does this PR do?

Fixes #2372

This PR introduces/refactors/...

Checklist before merging

  • Install pre-commit and initialize it: pip install pre-commit, then pre-commit install. Pre-commit installs git hooks that automatically check the codebase. If pre-commit fails when you commit your changes, please fix the problems it points out.
  • utACK

@keshav0479
Copy link
Contributor

Hey @GautamSingh0310 good work on the persistence ,the filters load and save to local storage.
I found one side effect: toggling Buy/Sell or Currency in the "Create Order" form changes the filters on the main Order Book page too. This happens because they share the same global fav state.
Hint: To fix this, try uncoupling them by adding type, currency, and mode to the
Maker.model.ts This way the form serves as its own local state and doesn't touch the global book filters until the order is submitted.

@GautamSingh0310
Copy link
Author

Hey @keshav0479 thanks for the review and hint, i will try it again an update it

@KoalaSat
Copy link
Member

Thank you all, please @GautamSingh0310 ping me once you are done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Store book filters in local storage

3 participants