Skip to content

Install the nodes, libraries and configurations.#36

Open
AlexisTM wants to merge 2 commits intoRoboSense-LiDAR:masterfrom
AlexisTM:feature/cmake_install_commands
Open

Install the nodes, libraries and configurations.#36
AlexisTM wants to merge 2 commits intoRoboSense-LiDAR:masterfrom
AlexisTM:feature/cmake_install_commands

Conversation

@AlexisTM
Copy link
Copy Markdown

@AlexisTM AlexisTM commented Jan 2, 2020

This allows using ros_rslidar in an installed catkin environment.

Copy link
Copy Markdown

@saikishor saikishor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are missing the install rules of nodelet_rslidar.xml and nodelets.xml in the packages rslidar_driver and rslidar_pointcloud

Copy link
Copy Markdown

@saikishor saikishor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@AlexReimann
Copy link
Copy Markdown

merge?

@saikishor
Copy link
Copy Markdown

yes. I think now it looks good!

@AlexReimann
Copy link
Copy Markdown

@Tony-HIT

@HaoQChen
Copy link
Copy Markdown
Contributor

HaoQChen commented Feb 7, 2021

Hi Alex, We are not going to maintain this project, please use our new driver rslidar_sdk

the new driver supports ROS, ROS2, and you can even use it in Windows without ROS or ROS2.

Sorry to take so long to reply you, Tony always be busy here and there

@saikishor
Copy link
Copy Markdown

Hello @HaoQChen,

If you are not maintaining this repo anymore, please do mention in a Readme the same and please put a link to your new driver, so please can redirect to the new package, else, it is really hard to find out.

I hope you understand

@HaoQChen
Copy link
Copy Markdown
Contributor

HaoQChen commented Feb 9, 2021

and

copy that, I have add it to README.

Wish you a happy Chinese New Year

@saikishor
Copy link
Copy Markdown

Awesome. That's what I am talking about. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants