-
-
Notifications
You must be signed in to change notification settings - Fork 65
Full Rebuild (Sync) July 2025: bump ros2-distro-mutex to 0.7.0 and build_number to 13 #320
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Tobias-Fischer
merged 138 commits into
RoboStack:main
from
traversaro:fullrebuild202507
Jul 23, 2025
Merged
Changes from all commits
Commits
Show all changes
138 commits
Select commit
Hold shift + click to select a range
00e9af3
Update conda_build_config.yaml based on ros-kilted one
traversaro 69ae462
Refresh rosdistro_snapshot.yaml
traversaro f73d1ae
Bump mutex package to 0.7.0 and build_number to 13
traversaro eb1cc07
Consolidate vinca files in a single vinca.yaml
traversaro ca2be6b
Get rid of all additional recipes
traversaro 48f0d5d
Get rid of useless beta environment in pixi.toml and just used default
traversaro 76240c5
Remove used of beta env in testpr.yml
traversaro a4cdd7e
Remove unneded patches and cleanup handling of vendor packages
traversaro cb09256
Support rev in rosdistro_additional_recipes to support wasm-related r…
traversaro 2b7bb62
Unvendor librealsense2 and updates patches
traversaro 534088c
Skip tests on emscripten-wasm32
traversaro e2d25f7
Cleanup patches
traversaro 2c2e1d2
cleanup patches
wep21 a9a3633
update patch
wep21 7c01c61
update patch deps
wep21 cd8077c
Merge pull request #1 from wep21/fullrebuild202507
traversaro cebef50
Update dependencies.yaml
traversaro abade35
override octomap version
wep21 93d189c
update win patch
wep21 018ad6a
Add caching to testpr jobs to simplify full rebuild and sync
traversaro 6d050c6
g2o only depend on qt-main not qt
traversaro 09bcd47
Remvoe cartographer from robostack.yaml
traversaro b9e2c30
Use eigenpy version compatible with pinocchio and coal
traversaro 057f92a
Bump vinca version
traversaro ce491a5
Create ros-humble-kinematics-interface.patch
traversaro c9ded63
Override cartographer version
traversaro 9374e56
Fix macos backward failure
traversaro 7a0b2bd
More unvendor
traversaro 419ee25
Fix cartographer_ros
traversaro d41551d
Create ros-humble-gripper-controllers.patch
traversaro 8a803c5
Restore gripper_controllers patch
traversaro 8ed9c94
Restore useful patches on Windows
traversaro 9627697
Fix patch
traversaro 383c1bd
Update qt-gui-cpp patch
traversaro 0b4f4bf
Remode upstreamed patch in control_toolbox
traversaro fb62b2d
Actually save cache in testpr.yml
traversaro 976543c
Skip some packages and give priority to conda-forge to avoid draco fr…
traversaro d2324c3
Create ros-humble-grid-map-cmake-helpers.patch
traversaro 541fe61
Update pkg_additional_info.yaml
traversaro ef887d8
Only build event_camera_* packages on Linux
traversaro f7c4cbd
Skip not supported packages on macos and try to fix Windows cache
traversaro f0f0d0e
Only build webots on Linux and add print packages added in cache in t…
traversaro 062051d
Create ros-humble-ffmpeg-image-transport.patch
traversaro 2fe6c71
Create ros-humble-py-binding-tools.patch
traversaro 4d3f032
Create ros-humble-py-binding-tools.win.patch
traversaro 93e46e4
Restore cache as early as possible in testpr
traversaro 1995b3f
Update testpr.yml
traversaro 9d6ea67
Update testpr.yml
traversaro 83b7029
Update testpr.yml
traversaro 617e4b2
Update testpr.yml
traversaro cd7fa19
Only build point_cloud_transport_plugins on Linux for now
traversaro b135d19
Create ros-humble-autoware-utils-debug.patch
traversaro d18f65d
Update vinca.yaml
traversaro d4bc057
Add apriltag windows patches
traversaro b7ccefb
Fix builds on macos and win
traversaro 6ce3727
Update dependencies.yaml
traversaro 529315e
Update dependencies.yaml
traversaro a98a6e8
Update dependencies.yaml
traversaro 2a4fa83
Fix autoware on Windows and remove Werror from foxglove video transport
traversaro 86b1b6b
Patch moveit packages
traversaro 9b45bea
Delete patch/ros-humble-moveit-ros-occupancy-map-monitor.patch
traversaro ef46501
Update vinca.yaml
traversaro 40be242
Update vinca.yaml
traversaro c4b6901
Rebuild pcl_ros with Windows support
traversaro 54e1c00
Fix cartographer_ros build
traversaro f9654f9
Update patch
traversaro e3edaed
Add tests for robot-state-publisher and skip cartographer_ros on Windows
traversaro 9bcc528
Save cache as artifact
traversaro ea0fe74
Update ros-humble-robot-state-publisher.yaml
traversaro fdeee0c
Update ros-humble-robot-state-publisher.yaml
traversaro 056a2f0
Update ros-humble-robot-state-publisher.yaml
traversaro 0cc1573
Update testpr.yml
traversaro 4107024
Update ros-humble-robot-state-publisher.yaml
traversaro d63412c
Fix tests for robot-state-publisher
traversaro 7c1a5c1
Fix cartographer_ros on Windows
traversaro 8a30302
Update ros-humble-diagnostic-updater.win.patch
traversaro c89180a
Update testpr.yml
traversaro 1b69f02
Delete patch/ros-humble-diagnostic-updater.win.patch
traversaro cc8d18b
Fix ros-gz-bridge and review comments
traversaro fd1d19c
Update ros-humble-ros-gz-bridge.win.patch
traversaro d6c1c6e
Update ros-humble-ros-gz-bridge.win.patch
traversaro 14d314a
Update ros-humble-ros-gz-bridge.win.patch
traversaro 4a5b656
Update ros-humble-ros-gz-bridge.win.patch
traversaro 6b404f5
Skip ros_gz on Windows on Humble
traversaro 9148350
Update vinca.yaml
traversaro 28713cd
Update ros-humble-foxglove-bridge.patch
Tobias-Fischer ccdd859
Update ros-humble-foxglove-bridge.patch
Tobias-Fischer 578459f
Update ros-humble-foxglove-bridge.patch
Tobias-Fischer 465ba3c
skip foxglove-bridge
Tobias-Fischer 67bcdb8
Create ros-humble-octomap-rviz-plugins.patch
Tobias-Fischer 1c24503
Delete patch/ros-humble-octomap-rviz-plugins.patch
Tobias-Fischer f0e2bcf
Switch default rmw on macOS to cyclonedds
traversaro d777f32
Fix windows build of octomap-rviz-plugins
traversaro a7d3e67
Fix rviz-default-plugins
traversaro f184f74
Fix octomap_ros on Windows
traversaro 86c7818
Do not build grid_map on Windows
traversaro a4a8a68
Fix patch name for rmw-implementation-cmake
traversaro afe5b72
Fix CI
traversaro 95e6bfa
Update robot_state_publisher_smoke_test_launch.py
traversaro 65a0863
Add moveit packages requested on macos
traversaro 1d3e0a3
Skip microstrain packages on Windows
traversaro 1ffc38e
Do not build motion_capture_tracking on Windows
traversaro 5e8fc30
Create ros-humble-moveit-setup-core-plugins.win.patch
traversaro 7e54462
Update ros-humble-nav2-amcl.win.patch
traversaro dd73803
Add nav2 windows patches
traversaro 91af93e
Remove incompatinle nav2 patches
traversaro 20f90c9
Remove incompatinle nav2 patches
traversaro fc0e182
Update ros-humble-nav2-waypoint-follower.win.patch
traversaro 4e13ae1
Update ros-humble-nav2-waypoint-follower.win.patch
traversaro 9fe7f0c
Update ros-humble-nav2-waypoint-follower.win.patch
traversaro 55a420c
Add win patch for slam toolbox
traversaro 2f6353f
Add data_tamer_cpp to vinca.yaml
traversaro 471b691
Fix windows data_tamer_cpp
traversaro be36dc7
Do not build slam_toolbox on Windows
traversaro 6f8204c
Create ros-humble-data-tamer-cpp.patch
traversaro 93ce503
Update ros-humble-data-tamer-cpp.patch
traversaro f757886
Update ros-humble-data-tamer-cpp.patch
traversaro 4eed3bc
Do not build nav2_bringup on Windows
traversaro 5fd0a82
Add blas-devel to packages that depends on suitesparse
traversaro f068820
Create ros-humble-slam-toolbox.win.patch
traversaro 316cf7a
Update ros-humble-slam-toolbox.win.patch
traversaro febaf07
Update ros-humble-slam-toolbox.win.patch
traversaro 49c7924
Update ros-humble-slam-toolbox.win.patch
traversaro a7d6e77
Do not build ublox on Windows
traversaro 414c7a7
Start full build for linux and macos and patch angles on Windows
traversaro 2f584b2
Fixes on Windows
traversaro 161a507
Add windows fix for robot-localization
traversaro a315776
Update vinca.yaml
traversaro 156a1f1
Update testpr.yml
traversaro 15fbd65
Do no build sick packages on Windows
traversaro ee4418e
Update vinca.yaml
traversaro 909991c
Create ros-humble-ur-controllers.win.patch
traversaro ddcff84
Add ur Windows patches
traversaro b9314c8
Fix ur-robot-driver patch
traversaro 6a850c2
Do not build velodyne_simulator on Windows
traversaro 9437795
Do not build vision-msgs-rviz-plugins on Windows
traversaro c98e554
Update testpr.yml
traversaro 1a41847
Minor cleanup
Tobias-Fischer File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -4,7 +4,8 @@ on: | |
|
||
env: | ||
ROS_VERSION: 2 | ||
|
||
# Change to 'true' to enable the cache upload as artifacts | ||
SAVE_CACHE_AS_ARTIFACT: 'false' | ||
jobs: | ||
build: | ||
strategy: | ||
|
@@ -13,16 +14,22 @@ jobs: | |
include: | ||
- os: ubuntu-latest | ||
platform: linux-64 | ||
folder_cache: 'output/linux-64' | ||
- os: ubuntu-24.04-arm | ||
platform: linux-aarch64 | ||
folder_cache: 'output/linux-aarch64' | ||
- os: macos-13 | ||
platform: osx-64 | ||
folder_cache: 'output/osx-64' | ||
- os: macos-14 | ||
platform: osx-arm64 | ||
folder_cache: 'output/osx-arm64' | ||
- os: windows-2022 | ||
platform: win-64 | ||
folder_cache: 'C:/bld/win-64' | ||
- os: ubuntu-latest | ||
platform: emscripten-wasm32 | ||
folder_cache: 'output/emscripten-wasm32' | ||
|
||
runs-on: ${{ matrix.os }} | ||
|
||
|
@@ -32,11 +39,18 @@ jobs: | |
persist-credentials: false # otherwise, the token used is the GITHUB_TOKEN, instead of your personal token | ||
fetch-depth: 0 # otherwise, you will failed to push refs to dest repo | ||
|
||
- uses: prefix-dev/[email protected].1 | ||
- uses: prefix-dev/[email protected].10 | ||
with: | ||
environments: beta | ||
frozen: true | ||
|
||
- name: Long paths workarounds for win-64 | ||
shell: bash -l {0} | ||
if: matrix.platform == 'win-64' | ||
run: | | ||
# Workaround for problem related to long paths | ||
echo "CONDA_BLD_PATH=C:\\bld\\" >> $GITHUB_ENV | ||
mkdir /c/bld | ||
|
||
# Workaround for https://github.com/RoboStack/ros-humble/pull/141#issuecomment-1941919816 | ||
- name: Clean up PATH | ||
if: contains(matrix.os, 'windows') | ||
|
@@ -56,119 +70,69 @@ jobs: | |
rm -rf /c/Strawberry | ||
rm -rf "/c/Program Files (x86)/Windows Kits/10/Include/10.0.17763.0/" | ||
|
||
- name: Check what files have changed | ||
id: filecheck | ||
shell: bash -l {0} | ||
run: | | ||
git fetch origin main | ||
# continue on error | ||
set +e | ||
git diff --exit-code --name-only origin/main -- vinca_linux_64.yaml > /dev/null | ||
echo "::set-output name=LINUX_YAML_CHANGED::${?}" | ||
git diff --exit-code --name-only origin/main -- vinca_emscripten32.yaml > /dev/null | ||
echo "::set-output name=EMSCRIPTEN32_YAML_CHANGED::${?}" | ||
git diff --exit-code --name-only origin/main -- vinca_linux_aarch64.yaml > /dev/null | ||
echo "::set-output name=LINUX_AARCH_YAML_CHANGED::${?}" | ||
git diff --exit-code --name-only origin/main -- vinca_osx.yaml > /dev/null | ||
echo "::set-output name=OSX_YAML_CHANGED::${?}" | ||
git diff --exit-code --name-only origin/main -- vinca_osx_arm64.yaml > /dev/null | ||
echo "::set-output name=OSX_ARM_YAML_CHANGED::${?}" | ||
git diff --exit-code --name-only origin/main -- vinca_win.yaml > /dev/null | ||
echo "::set-output name=WIN_YAML_CHANGED::${?}" | ||
- name: Generate recipes for linux-64 | ||
shell: bash -l {0} | ||
if: matrix.platform == 'linux-64' | ||
run: | | ||
cp vinca_linux_64.yaml vinca.yaml | ||
mkdir -p recipes | ||
$HOME/.pixi/bin/pixi run -e beta -v vinca --platform linux-64 -m | ||
ls -la recipes | ||
- name: Generate recipes for emscripten-wasm32 | ||
shell: bash -l {0} | ||
if: steps.filecheck.outputs.EMSCRIPTEN32_YAML_CHANGED == 1 && matrix.platform == 'emscripten-wasm32' | ||
run: | | ||
cp vinca_emscripten32.yaml vinca.yaml | ||
mkdir -p recipes | ||
$HOME/.pixi/bin/pixi run -e beta -v vinca --platform emscripten-wasm32 -m -n | ||
ls -la recipes | ||
- name: Generate recipes for linux-aarch64 | ||
shell: bash -l {0} | ||
if: matrix.platform == 'linux-aarch64' | ||
run: | | ||
cp vinca_linux_aarch64.yaml vinca.yaml | ||
mkdir -p recipes | ||
$HOME/.pixi/bin/pixi run -e beta -v vinca --platform linux-aarch64 -m | ||
ls -la recipes | ||
- name: Generate recipes for osx-64 | ||
shell: bash -l {0} | ||
if: matrix.platform == 'osx-64' | ||
run: | | ||
cp vinca_osx.yaml vinca.yaml | ||
mkdir -p recipes | ||
$HOME/.pixi/bin/pixi run -e beta -v vinca --platform osx-64 -m | ||
ls -la recipes | ||
- name: Generate recipes for osx-arm64 | ||
# Regression for https://github.com/RoboStack/ros-jazzy/issues/44 | ||
- name: Check that anaconda-client command works fine | ||
shell: bash -l {0} | ||
if: matrix.platform == 'osx-arm64' | ||
run: | | ||
cp vinca_osx_arm64.yaml vinca.yaml | ||
mkdir -p recipes | ||
$HOME/.pixi/bin/pixi run -e beta -v vinca --platform osx-arm64 -m | ||
ls -la recipes | ||
- name: Generate recipes for win-64 | ||
pixi run anaconda --version | ||
|
||
- name: Generate recipes | ||
shell: bash -l {0} | ||
if: matrix.platform == 'win-64' | ||
run: | | ||
# Workaround for problem related to long paths | ||
echo "CONDA_BLD_PATH=C:\\bld\\" >> $GITHUB_ENV | ||
mkdir /c/bld | ||
cp vinca_win.yaml vinca.yaml | ||
mkdir -p recipes | ||
$HOME/.pixi/bin/pixi run -e beta -v vinca --platform win-64 -m | ||
ls -la recipes | ||
- name: Check if there are packages to be built | ||
id: newrecipecheck | ||
shell: bash -l {0} | ||
run: | | ||
set +e | ||
if [ ! -d recipes ] || [ -z "$(ls -A recipes)" ]; then | ||
echo "RECIPE_CREATED=0" >> $GITHUB_OUTPUT | ||
else | ||
echo "RECIPE_CREATED=1" >> $GITHUB_OUTPUT | ||
fi | ||
- name: Build recipes for linux-64 | ||
shell: bash -l {0} | ||
if: steps.newrecipecheck.outputs.RECIPE_CREATED == 1 && matrix.platform == 'linux-64' | ||
run: | | ||
env -i $HOME/.pixi/bin/pixi run -e beta rattler-build build --recipe-dir additional_recipes --target-platform linux-64 -m ./conda_build_config.yaml -c robostack-staging -c conda-forge --skip-existing | ||
env -i $HOME/.pixi/bin/pixi run -e beta rattler-build build --recipe-dir recipes --target-platform linux-64 -m ./conda_build_config.yaml -c robostack-staging -c conda-forge --skip-existing | ||
- name: Build recipes for emscripten-wasm32 | ||
pixi run -v vinca --platform ${{ matrix.platform }} -m -n | ||
|
||
- name: Check patches | ||
shell: bash -l {0} | ||
if: steps.newrecipecheck.outputs.RECIPE_CREATED == 1 && steps.filecheck.outputs.EMSCRIPTEN32_YAML_CHANGED == 1 && matrix.platform == 'emscripten-wasm32' | ||
run: | | ||
env -i $HOME/.pixi/bin/pixi run -e beta sh -c 'find additional_recipes/* -maxdepth 0 -type d -exec ln -s ../{} recipes/ \;' | ||
env -i $HOME/.pixi/bin/pixi run -e beta rattler-build build --recipe-dir ./recipes --target-platform emscripten-wasm32 -m ./conda_build_config.yaml -c https://repo.mamba.pm/emscripten-forge/ -c robostack-staging -c conda-forge --skip-existing --test skip | ||
- name: Build recipes for linux-aarch64 | ||
pixi run python check_patches_clean_apply.py | ||
|
||
- name: Restore build cache | ||
id: cache-restore | ||
uses: actions/cache/restore@v4 | ||
with: | ||
path: | | ||
${{ matrix.folder_cache }} | ||
key: ${{ runner.os }}-${{ matrix.platform }}-pr-${{ github.event.pull_request.number }} | ||
# allow a later run to pick up a cache that has an extra suffix | ||
restore-keys: | | ||
${{ runner.os }}-${{ matrix.platform }}-pr-${{ github.event.pull_request.number }}- | ||
|
||
- name: See packages restored by cache | ||
shell: bash -l {0} | ||
if: steps.newrecipecheck.outputs.RECIPE_CREATED == 1 && matrix.platform == 'linux-aarch64' | ||
run: | | ||
env -i $HOME/.pixi/bin/pixi run -e beta rattler-build build --recipe-dir additional_recipes --target-platform linux-aarch64 -m ./conda_build_config.yaml -c robostack-staging -c conda-forge --skip-existing | ||
env -i $HOME/.pixi/bin/pixi run -e beta rattler-build build --recipe-dir recipes --target-platform linux-aarch64 -m ./conda_build_config.yaml -c robostack-staging -c conda-forge --skip-existing | ||
- name: Build recipes for osx-64 | ||
ls ${{ matrix.folder_cache }} | ||
|
||
- name: Build recipes [non emscripten] | ||
shell: bash -l {0} | ||
if: steps.newrecipecheck.outputs.RECIPE_CREATED == 1 && matrix.platform == 'osx-64' | ||
if: matrix.platform != 'emscripten-wasm32' | ||
run: | | ||
env -i $HOME/.pixi/bin/pixi run -e beta rattler-build build --recipe-dir additional_recipes --target-platform osx-64 -m ./conda_build_config.yaml -c robostack-staging -c conda-forge --skip-existing | ||
env -i $HOME/.pixi/bin/pixi run -e beta rattler-build build --recipe-dir recipes --target-platform osx-64 -m ./conda_build_config.yaml -c robostack-staging -c conda-forge --skip-existing | ||
- name: Build recipes for osx-arm64 | ||
pixi run rattler-build build --recipe-dir recipes --target-platform ${{ matrix.platform }} -m ./conda_build_config.yaml -c conda-forge -c robostack-staging --skip-existing | ||
|
||
- name: Build recipes [emscripten] | ||
shell: bash -l {0} | ||
if: steps.newrecipecheck.outputs.RECIPE_CREATED == 1 && matrix.platform == 'osx-arm64' | ||
if: matrix.platform == 'emscripten-wasm32' | ||
run: | | ||
env -i $HOME/.pixi/bin/pixi run -e beta rattler-build build --recipe-dir additional_recipes --target-platform osx-arm64 -m ./conda_build_config.yaml -c robostack-staging -c conda-forge --skip-existing | ||
env -i $HOME/.pixi/bin/pixi run -e beta rattler-build build --recipe-dir recipes --target-platform osx-arm64 -m ./conda_build_config.yaml -c robostack-staging -c conda-forge --skip-existing | ||
- name: Build recipes for win-64 | ||
pixi run rattler-build build --recipe-dir recipes --target-platform ${{ matrix.platform }} -m ./conda_build_config.yaml -c https://repo.mamba.pm/emscripten-forge/ -c conda-forge -c robostack-staging --skip-existing --test skip | ||
|
||
- name: See packages that will be saved in cache | ||
shell: bash -l {0} | ||
if: steps.newrecipecheck.outputs.RECIPE_CREATED == 1 && matrix.platform == 'win-64' | ||
if: always() | ||
run: | | ||
$HOME/.pixi/bin/pixi run -e beta rattler-build build --recipe-dir additional_recipes --target-platform win-64 -m ./conda_build_config.yaml -c robostack-staging -c conda-forge --skip-existing | ||
$HOME/.pixi/bin/pixi run -e beta rattler-build build --recipe-dir recipes -m ./conda_build_config.yaml --target-platform win-64 -c robostack-staging -c conda-forge --skip-existing | ||
ls ${{ matrix.folder_cache }} | ||
|
||
- name: Save build cache | ||
uses: actions/cache/save@v4 | ||
if: always() | ||
with: | ||
path: | | ||
${{ matrix.folder_cache }} | ||
key: ${{ runner.os }}-${{ matrix.platform }}-pr-${{ github.event.pull_request.number }}-${{ github.run_id }}-${{ github.run_attempt }} | ||
|
||
- name: Upload build cache as artifact | ||
if: ${{ always() && env.SAVE_CACHE_AS_ARTIFACT == 'true' }} | ||
uses: actions/upload-artifact@v4 | ||
with: | ||
name: cache-${{ matrix.platform }}-${{ github.run_id }} | ||
path: ${{ matrix.folder_cache }} | ||
retention-days: 7 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,8 +1,5 @@ | ||
vinca.yaml | ||
recipes/ | ||
*.bat | ||
*.sh | ||
*.ps1 | ||
recipes_only_patch/ | ||
*.json | ||
.DS_Store | ||
# pixi environments | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.