Skip to content

Feat: Add usb-cam to linux builds #73

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 16, 2025
Merged

Feat: Add usb-cam to linux builds #73

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
d3c1c4e
Add usb-cam to linux builds
elephantum Jun 16, 2025
5fe8490
Add usb-cam patch from ros-drivers/usb_cam#343
elephantum Jun 16, 2025
ac28fb8
also disable warnings as errors
elephantum Jun 16, 2025
c731588
add trailing EOL to patch
elephantum Jun 16, 2025
aae04e1
migrate patch to tagged version of code (ros2-gbp/usb_cam-release at …
elephantum Jun 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 29 additions & 0 deletions patch/ros-jazzy-usb-cam.patch
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,29 @@
diff --git a/CMakeLists.txt b/CMakeLists.txt
index 2387c32..0413704 100644
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -8,7 +8,7 @@ endif()

if(CMAKE_COMPILER_IS_GNUCXX OR CMAKE_CXX_COMPILER_ID MATCHES "Clang")
if($ENV{ROS_VERSION} EQUAL 2)
- add_compile_options(-Wall -Wextra -Wpedantic -Werror)
+ add_compile_options(-Wall -Wextra -Wpedantic)
endif()
endif()

diff --git a/include/usb_cam/formats/av_pixel_format_helper.hpp b/include/usb_cam/formats/av_pixel_format_helper.hpp
index ad1792e..1ea720d 100644
--- a/include/usb_cam/formats/av_pixel_format_helper.hpp
+++ b/include/usb_cam/formats/av_pixel_format_helper.hpp
@@ -744,11 +744,6 @@ const std::unordered_map<std::string, AVPixelFormat> STR_2_AVPIXFMT = {
///< big-endian


- {stringify(AV_PIX_FMT_XVMC), AV_PIX_FMT_XVMC}, ///< XVideo Motion
- ///< Acceleration via common
- ///< packet passing
-
-
{stringify(AV_PIX_FMT_YUV440P10LE), AV_PIX_FMT_YUV440P10LE}, ///< planar YUV 4:4:0,20bpp,
///< (1 Cr & Cb sample per
///< 1x2 Y samples),
2 changes: 2 additions & 0 deletions vinca_linux_64.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,5 +149,7 @@ packages_select_by_deps:

- ouster_ros

- usb-cam

patch_dir: patch
rosdistro_snapshot: rosdistro_snapshot.yaml
2 changes: 2 additions & 0 deletions vinca_linux_aarch64.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,5 +147,7 @@ packages_select_by_deps:

- ouster_ros

- usb-cam

patch_dir: patch
rosdistro_snapshot: rosdistro_snapshot.yaml