fix: remove the hardcoded rmw implementation on darwin #68
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @ruben-arts ! The change seems fine for me. After this PR is merged to actually fix the problem, we also need to rebuild the |
traversaro
approved these changes
Jan 15, 2025
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From a conversation with @traversaro I understand that this isn't required anymore. Feel free to close if that was a miss interpretation and I will make an issue for it.
The issue was found because setting the
RMW_IMPLEMENTATIONenv var before the activation doesn't work on Mac. As it will be overwritten by this line. See the spark for debugging session here: prefix-dev/pixi#2910