Skip to content

fix: resolve TypeScript type errors #247

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Robot-Inventor merged 1 commit into from
Nov 17, 2024
Merged

fix: resolve TypeScript type errors #247

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions rspack.config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ class RunCommandsPlugin {

isFirstRun = false;

if (this.env.updateUserScripts) {
if (this.env["updateUserScripts"]) {
exec("npx tsx ./script/addUserScriptComment.ts", (err, stdout) => {
if (err) {
// eslint-disable-next-line no-console
Expand All @@ -80,7 +80,7 @@ class RunCommandsPlugin {
}
}

const isProduction = process.env.NODE_ENV === "production";
const isProduction = process.env["NODE_ENV"] === "production";
/* eslint-disable sort-keys */
// eslint-disable-next-line max-lines-per-function
const config = defineConfig((env) => ({
Expand All @@ -89,7 +89,7 @@ const config = defineConfig((env) => ({
entry: {
"./chrome/js/index.js": "./src/ts/index.ts",
"./firefox/js/index.js": "./src/ts/index.ts",
...(env.updateUserScripts ? { "../index.user.js": "./src/ts/index.ts" } : {})
...(env["updateUserScripts"] ? { "../index.user.js": "./src/ts/index.ts" } : {})
},
output: {
filename: "[name]",
Expand Down