Skip to content

fix bug in crop to bounds#617

Open
manuelli wants to merge 1 commit intoRobotLocomotion:masterfrom
manuelli:lm-crop-to-bounds
Open

fix bug in crop to bounds#617
manuelli wants to merge 1 commit intoRobotLocomotion:masterfrom
manuelli:lm-crop-to-bounds

Conversation

@manuelli
Copy link
Collaborator

@manuelli manuelli commented Mar 4, 2019

Previously zip was only traversing X and Y axes, not Z.

@manuelli manuelli requested a review from patmarion March 4, 2019 23:12
@patmarion
Copy link
Member

patmarion commented Mar 4, 2019

maybe just the doc string is wrong? It works if bounds is a 3x2 instead of a 2x3?

@manuelli
Copy link
Collaborator Author

manuelli commented Mar 4, 2019

Yeah that's probably right. The only other usage is in drilldemo and they pass in a list of lists. The original list is length 3. So yeah seems like just an update on the documentation is needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants