Skip to content

[drake_bazel_download] Add linkopts for spdlog and fmt#514

Merged
SeanCurtis-TRI merged 1 commit intoRobotLocomotion:mainfrom
jwnimmer-tri:drake-bazel-download-link-spdlog
Mar 12, 2026
Merged

[drake_bazel_download] Add linkopts for spdlog and fmt#514
SeanCurtis-TRI merged 1 commit intoRobotLocomotion:mainfrom
jwnimmer-tri:drake-bazel-download-link-spdlog

Conversation

@jwnimmer-tri
Copy link
Contributor

@jwnimmer-tri jwnimmer-tri commented Mar 12, 2026

The recent change to Drake RobotLocomotion/drake#24202 uncovered a latent bug in this BUILD recipe for how to link the Drake shared library. When linking libdrake, we also need to link its dependencies.


This change is Reviewable

Copy link
Contributor

@SeanCurtis-TRI SeanCurtis-TRI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:LGTM:

@SeanCurtis-TRI reviewed 1 file and all commit messages, and made 1 comment.
Reviewable status: :shipit: complete! all discussions resolved, platform LGTM from [seancurtis-tri] (waiting on jwnimmer-tri).

@SeanCurtis-TRI SeanCurtis-TRI merged commit 5563173 into RobotLocomotion:main Mar 12, 2026
12 checks passed
@jwnimmer-tri jwnimmer-tri deleted the drake-bazel-download-link-spdlog branch March 12, 2026 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants