Skip to content

Commit df758f7

Browse files
committed
Address comments
1 parent 3991d0e commit df758f7

File tree

3 files changed

+3
-1
lines changed

3 files changed

+3
-1
lines changed

lib/node.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -598,6 +598,7 @@ class Node extends rclnodejs.ShadowNode {
598598
* @param {object} options - The options argument used to parameterize the publisher.
599599
* @param {boolean} options.enableTypedArray - The topic will use TypedArray if necessary, default: true.
600600
* @param {QoS} options.qos - ROS Middleware "quality of service" settings for the publisher, default: QoS.profileDefault.
601+
* @param {PublisherEventCallbacks} eventCallbacks - The event callbacks for the publisher.
601602
* @return {Publisher} - An instance of Publisher.
602603
*/
603604
createPublisher(typeClass, topic, options, eventCallbacks) {

src/executor.cpp

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,7 @@
2222
#include "handle_manager.h"
2323
#include "macros.h"
2424
#include "rcl_bindings.h"
25+
2526
#ifdef WIN32
2627
#define UNUSED
2728
#else

test/test-type-description-service.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ describe('type description service test suite', function () {
3535
const nodeName = 'test_type_description_service';
3636
node = rclnodejs.createNode(nodeName);
3737
rclnodejs.spin(node);
38-
await assertUtils.createDelay(5000);
38+
await assertUtils.createDelay(1000);
3939
});
4040

4141
afterEach(function () {

0 commit comments

Comments
 (0)