Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion lib/client.js
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,6 @@ class Client extends Entity {
request instanceof this._typeClass.Request
? request
: new this._typeClass.Request(request);
requestToSend._willCheckConsistency = this._options.willCheckConsistency;

let rawRequest = requestToSend.serialize();
let sequenceNumber = rclnodejs.sendRequest(this._handle, rawRequest);
Expand Down
7 changes: 0 additions & 7 deletions lib/node.js
Original file line number Diff line number Diff line change
Expand Up @@ -502,10 +502,6 @@ class Node extends rclnodejs.ShadowNode {
options = Object.assign(options, { isRaw: false });
}

if (options.willCheckConsistency === undefined) {
options = Object.assign(options, { willCheckConsistency: false });
}

return options;
}

Expand Down Expand Up @@ -592,7 +588,6 @@ class Node extends rclnodejs.ShadowNode {
* @param {object} options - The options argument used to parameterize the publisher.
* @param {boolean} options.enableTypedArray - The topic will use TypedArray if necessary, default: true.
* @param {QoS} options.qos - ROS Middleware "quality of service" settings for the publisher, default: QoS.profileDefault.
* @param {boolean} options.willCheckConsistency - Pulisher will check the consistancy of the message to be sent, default: false.
* @return {Publisher} - An instance of Publisher.
*/
createPublisher(typeClass, topic, options) {
Expand Down Expand Up @@ -695,7 +690,6 @@ class Node extends rclnodejs.ShadowNode {
* @param {object} options - The options argument used to parameterize the client.
* @param {boolean} options.enableTypedArray - The response will use TypedArray if necessary, default: true.
* @param {QoS} options.qos - ROS Middleware "quality of service" settings for the client, default: QoS.profileDefault.
* @param {boolean} options.willCheckConsistency - Client will check the consistancy of the message to be sent, default: false.
* @return {Client} - An instance of Client.
*/
createClient(typeClass, serviceName, options) {
Expand Down Expand Up @@ -1696,7 +1690,6 @@ Node.getDefaultOptions = function () {
isRaw: false,
qos: QoS.profileDefault,
contentFilter: undefined,
willCheckConsistency: false,
};
};

Expand Down
1 change: 0 additions & 1 deletion lib/publisher.js
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,6 @@ class Publisher extends Entity {
message instanceof this._typeClass
? message
: new this._typeClass(message);
messageToSend._willCheckConsistency = this._options.willCheckConsistency;
let rawMessage = messageToSend.serialize();
rclnodejs.publish(this._handle, rawMessage);
}
Expand Down
4 changes: 2 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,6 @@
"jsdoc": "^4.0.4",
"lint-staged": "^15.2.10",
"mocha": "^11.0.2",
"prettier": "^3.4.2",
"sinon": "^19.0.2",
"tree-kill": "^1.2.2",
"typescript": "^5.7.2"
Expand All @@ -83,7 +82,8 @@
"nan": "^2.22.0",
"rimraf": "^6.0.1",
"uuid": "^11.0.3",
"walk": "^2.3.15"
"walk": "^2.3.15",
"prettier": "^3.4.2"
},
"husky": {
"hooks": {
Expand Down
2 changes: 1 addition & 1 deletion rosidl_gen/generator.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "rosidl-generator",
"version": "0.3.10",
"version": "0.4.0",
"description": "Generate JavaScript object from ROS IDL(.msg) files",
"main": "index.js",
"authors": [
Expand Down
4 changes: 4 additions & 0 deletions rosidl_gen/idl_generator.js
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@
'use strict';

const dot = require('dot');
const prettier = require('prettier');
const fse = require('fs-extra');
const path = require('path');
const parser = require('../rosidl_parser/rosidl_parser.js');
Expand All @@ -40,6 +41,9 @@ function removeEmptyLines(str) {
* @param {string} code
*/
async function writeGeneratedCode(dir, fileName, code) {
if (fileName.endsWith('.js')) {
code = await prettier.format(code, { parser: 'babel' });
}
await fse.mkdirs(dir);
await fse.writeFile(path.join(dir, fileName), code);
}
Expand Down
Loading
Loading