Remove invalid escape sequence #1033
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
minggangw
force-pushed
the
remove-invalid-escape
branch
3 times, most recently
from
655cd4e to
493522c
Compare
minggangw
force-pushed
the
remove-invalid-escape
branch
from
493522c to
3c1c585
Compare
minggangw
added a commit
that referenced
this pull request
Feb 18, 2025
Currently, when executing `node-gyp` to build the C++ addon, it has the following warnings: ```bash <string>:111: SyntaxWarning: invalid escape sequence '\/' <string>:1[19](https://github.com/RobotWebTools/rclnodejs/actions/runs/13325047285/job/37216429264#step:7:20): SyntaxWarning: invalid escape sequence '\l' <string>:128: SyntaxWarning: invalid escape sequence '\/' <string>:129: SyntaxWarning: invalid escape sequence '\/' <string>:130: SyntaxWarning: invalid escape sequence '\/' <string>:131: SyntaxWarning: invalid escape sequence '\/' <string>:132: SyntaxWarning: invalid escape sequence '\/' <string>:133: SyntaxWarning: invalid escape sequence '\/' <string>:134: SyntaxWarning: invalid escape sequence '\/' <string>:135: SyntaxWarning: invalid escape sequence '\/' <string>:136: SyntaxWarning: invalid escape sequence '\/' <string>:137: SyntaxWarning: invalid escape sequence '\/' <string>:138: SyntaxWarning: invalid escape sequence '\/' <string>:139: SyntaxWarning: invalid escape sequence '\/' <string>:140: SyntaxWarning: invalid escape sequence '\/' <string>:141: SyntaxWarning: invalid escape sequence '\/' <string>:142: SyntaxWarning: invalid escape sequence '\/' ``` This patch leverages the `path` module to remove platform-specific code, which caused the invalid escape sequence, including: 1. Add `config.js` to grab the path of ROS path, library path and include path programmatically. 2. Call functions defined in `config.js` and assign the returned value to `include_dirs` and `library_dirs` in `binding.gyp`. Fix: #1034
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, when executing
node-gypto build the C++ addon, it has the following warnings:This patch leverages the
pathmodule to remove platform-specific code, which caused the invalid escape sequence, including:config.jsto grab the path of ROS path, library path and include path programmatically.config.jsand assign the returned value toinclude_dirsandlibrary_dirsinbinding.gyp.Fix: #1034