Remove dependency array.prototype.flat #1049
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
PR Overview
This PR removes the dependency on the external polyfill for Array.prototype.flat by using the native implementation.
- Removes the import of the "array.prototype.flat" dependency.
- Simplifies the code by eliminating the conditional check and always using the native flat() method.
Reviewed Changes
| File | Description |
|---|---|
| rosidl_gen/packages.js | Removes dependency and fallback for Array.prototype.flat. |
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
|
|
||
| // Support flat() method for nodejs < 11. | ||
| const rosFiles = Array.prototype.flat ? files.flat() : flat(files); | ||
| const rosFiles = files.flat(); |
There was a problem hiding this comment.
By removing the dependency and conditional fallback, the code now assumes that Array.prototype.flat is always available. Please ensure the project's minimum Node.js version is set to 11 or higher to avoid runtime issues.
minggangw
added a commit
that referenced
this pull request
Mar 6, 2025
This patch removes dependency, `array.prototype.flat`, needed for nodejs prior to version 11. Fix: #1048
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch removes dependency,
array.prototype.flat, needed for nodejs prior to version 11.Fix: #1048