Add missing methods for graph #1110
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR adds new graph-related methods to expose publisher and subscription information by topic.
- Introduces native bindings and corresponding JavaScript wrappers for retrieving publishers and subscriptions info.
- Adds test coverage in both TypeScript and JavaScript test files to verify the new functionality.
- Updates build configuration and dependency lists to support the added functionality.
Reviewed Changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| test/types/index.test-d.ts | Added type assertions for the new graph methods. |
| test/test-graph.js | New tests verifying retrieval of publishers and subscriptions info. |
| src/rcl_utilities.h / .cpp | Added conversion functions for topic endpoint information. |
| src/rcl_node_bindings.cpp | Introduced new GetNodeNames method. |
| src/rcl_graph_bindings.cpp | Added refactored helper and new endpoints for publishers and subscriptions. |
| src/rcl_client_bindings.cpp | Added ServiceServerIsAvailable method for client bindings. |
| scripts/config.js | Updated dependencies to include rcpputils. |
| lib/node.js | Added JS wrapper methods for accessing new graph functions. |
| binding.gyp | Included linking flag for rcpputils. |
| it('Get publishers info by topic', function () { | ||
| const node = rclnodejs.createNode('publisher_node'); | ||
| const String = 'std_msgs/msg/String'; | ||
| node.createPublisher(String, 'topic'); |
There was a problem hiding this comment.
The test for publishers info uses '/topic' while the created publisher uses 'topic'. Consider ensuring consistency in topic naming between creation and retrieval to avoid potential mismatches.
Suggested change
| node.createPublisher(String, 'topic'); | |
| node.createPublisher(String, '/topic'); |
minggangw
added a commit
that referenced
this pull request
Apr 30, 2025
This PR adds new graph-related methods to expose publisher and subscription information by topic. - Introduces native bindings and corresponding JavaScript wrappers for retrieving publishers and subscriptions info. - Adds test coverage in both TypeScript and JavaScript test files to verify the new functionality. - Updates build configuration and dependency lists to support the added functionality. Fix: #1111
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds new graph-related methods to expose publisher and subscription information by topic.
Fix: #1111