Add typescript interface for the added new functions #1112
Merged
+57
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR introduces TypeScript interface tests for several new functions in rclnodejs. Key changes include:
- Adding a new constant (SERVICE_NAME) for service-related tests.
- Introducing type validations for new Context, Node, and Timer functions.
- Adding tests to verify the return types of functions like countClients, countServices, changeTimerPeriod, timerPeriod, and callTimerWithInfo.
| expectType<void>(timer.cancel()); | ||
| expectType<void>(timer.changeTimerPeriod(BigInt(100000))); | ||
| expectType<bigint>(timer.timerPeriod()); | ||
| expectType<object>(timer.callTimerWithInfo()); |
There was a problem hiding this comment.
[nitpick] Consider using a more specific interface type for 'timer.callTimerWithInfo()' instead of the generic 'object', to enhance type safety and clarity.
minggangw
added a commit
that referenced
this pull request
Apr 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds typescript interface for the newly added functions, see #1106 #1108
Fix: #1113