Add missing methods for client #1114
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR adds the missing client methods by implementing and exposing a getOptions function for services. The changes include updating TypeScript tests to verify the new method, adding a new service options test in JavaScript, implementing the ConvertToQoS function in C++ along with the GetOptions binding, and adding a getOptions method in the Service JavaScript class.
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| test/types/index.test-d.ts | Added a type assertion for service.getOptions(). |
| test/test-service.js | Added a new test verifying the returned service options from getOptions(). |
| src/rcl_utilities.h | Declared the ConvertToQoS function to support new QoS conversions. |
| src/rcl_utilities.cpp | Moved/reintroduced the implementation of ConvertToQoS with updated namespace usage. |
| src/rcl_service_bindings.cpp | Added the GetOptions binding and exported getOptions through the service bindings. |
| lib/service.js | Added the getOptions method to the Service class to expose service option functionality. |
| RclHandle::Unwrap(info[0].As<Napi::Object>())->ptr()); | ||
|
|
||
| const rcl_service_options_t* options = rcl_service_get_options(service); | ||
| auto qos_profile = ConvertToQoS(env, &options->qos); |
There was a problem hiding this comment.
[nitpick] Consider using the fully qualified name 'rclnodejs::ConvertToQoS' for clarity and consistency with its usage elsewhere in the codebase.
Suggested change
| auto qos_profile = ConvertToQoS(env, &options->qos); | |
| auto qos_profile = rclnodejs::ConvertToQoS(env, &options->qos); |
minggangw
added a commit
that referenced
this pull request
May 6, 2025
This PR adds the missing client methods by implementing and exposing a getOptions function for services. The changes include updating TypeScript tests to verify the new method, adding a new service options test in JavaScript, implementing the ConvertToQoS function in C++ along with the GetOptions binding, and adding a getOptions method in the Service JavaScript class. Fix: #1115
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the missing client methods by implementing and exposing a getOptions function for services. The changes include updating TypeScript tests to verify the new method, adding a new service options test in JavaScript, implementing the ConvertToQoS function in C++ along with the GetOptions binding, and adding a getOptions method in the Service JavaScript class.
Fix: #1115