Move configure client introspection to binding of client #1116
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the introspection configuration by shifting the client-specific introspection logic into its dedicated binding while cleaning up the service bindings.
- In src/rcl_service_bindings.cpp, the conditional branch for client introspection is removed and the service introspection configuration is streamlined.
- In src/rcl_client_bindings.cpp, a new function ConfigureClientIntrospection is introduced and exported for client use.
- In lib/service.js and lib/client.js, calls are updated to use the appropriate introspection functions and argument signatures.
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/rcl_service_bindings.cpp | Removed the client branch and streamlined service introspection. |
| src/rcl_client_bindings.cpp | Introduced a new client introspection function and updated exports. |
| lib/service.js | Updated function call signature to remove unused parameter. |
| lib/client.js | Changed the introspection function call to use the client version. |
minggangw
added a commit
that referenced
this pull request
May 6, 2025
This PR refactors the introspection configuration by shifting the client-specific introspection logic into its dedicated binding while cleaning up the service bindings. - In src/rcl_service_bindings.cpp, the conditional branch for client introspection is removed and the service introspection configuration is streamlined. - In src/rcl_client_bindings.cpp, a new function ConfigureClientIntrospection is introduced and exported for client use. - In lib/service.js and lib/client.js, calls are updated to use the appropriate introspection functions and argument signatures. Fix: #1117
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors the introspection configuration by shifting the client-specific introspection logic into its dedicated binding while cleaning up the service bindings.
Fix: #1117