Support getting the lifecycle state machine status #1136
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR introduces support for retrieving the lifecycle state machine status by adding a new "isInitialized" property.
- Added a type test for the new boolean property in the TypeScript tests.
- Implemented a corresponding native binding in C++ to expose the state.
- Exposed the property via a getter in the JavaScript lifecycle module.
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| test/types/index.test-d.ts | Added a type test to ensure isInitialized returns a boolean. |
| test/test-lifecycle.js | Added an assertion verifying that isInitialized is true. |
| src/rcl_lifecycle_bindings.cpp | Introduced the IsInitialized native binding and exported it. |
| lib/lifecycle.js | Provided a getter property that leverages the new native binding. |
minggangw
added a commit
that referenced
this pull request
May 23, 2025
This PR introduces support for retrieving the lifecycle state machine status by adding a new "isInitialized" property. - Added a type test for the new boolean property in the TypeScript tests. - Implemented a corresponding native binding in C++ to expose the state. - Exposed the property via a getter in the JavaScript lifecycle module. Fix: #1135
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces support for retrieving the lifecycle state machine status by adding a new "isInitialized" property.
Fix: #1135