Add Humble into arm workflow #1157
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR aims to update the build and test workflows to include the ROS distribution "humble" for the ARM environment.
- Removed the ROS distribution mapping (including "humble") from the Windows workflow.
- Added "humble" to the ROS distribution list and provided a corresponding docker image mapping in the linux-arm64 workflow.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| .github/workflows/windows-build-and-test.yml | Removed the include block mapping ROS distributions, possibly to disable "humble" testing on Windows. |
| .github/workflows/linux-arm64-build-and-test.yml | Added "humble" to the distribution list and inserted an include block with a docker image for "humble". |
Comments suppressed due to low confidence (3)
.github/workflows/windows-build-and-test.yml:27
- Removal of the ROS distribution mapping in the Windows workflow may require updating the project documentation to clarify which distributions are now supported on Windows.
- include:
.github/workflows/linux-arm64-build-and-test.yml:33
- Ensure that the addition of 'humble' in the ros_distribution list is fully supported by the ARM build environment and any necessary environment configurations are updated accordingly.
- humble
.github/workflows/linux-arm64-build-and-test.yml:37
- [nitpick] Confirm that the selected docker image 'ubuntu:jammy' for 'humble' is appropriate and consistent with the testing requirements for this ROS distribution.
# Humble Hawksbill (May 2022 - May 2027)
minggangw
added a commit
that referenced
this pull request
Jun 6, 2025
This PR aims to update the build and test workflows to include the ROS distribution "humble" for the ARM environment. - Removed the ROS distribution mapping (including "humble") from the Windows workflow. - Added "humble" to the ROS distribution list and provided a corresponding docker image mapping in the linux-arm64 workflow. Fix: #1156
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to update the build and test workflows to include the ROS distribution "humble" for the ARM environment.
Fix: #1156