Fix flakiness of test-message-type.js #1171
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR addresses the flakiness of test-message-type.js by ensuring that subscriptions are properly destroyed after each test execution.
- Added node.destroySubscription(subscription) to each test callback following publisher.kill('SIGINT') to ensure a clean test environment.
- Improves test reliability by explicitly cleaning up subscriptions in all message type tests.
| 'Bool_channel', | ||
| (msg) => { | ||
| publisher.kill('SIGINT'); | ||
| node.destroySubscription(subscription); |
There was a problem hiding this comment.
The subscription destruction logic is duplicated across multiple tests. Consider extracting this cleanup code into a common teardown hook (e.g., an afterEach block) to improve maintainability and reduce code duplication.
Suggested change
| node.destroySubscription(subscription); | |
| currentSubscription = { node, subscription }; |
minggangw
added a commit
that referenced
this pull request
Jun 18, 2025
This PR addresses the flakiness of test-message-type.js by ensuring that subscriptions are properly destroyed after each test execution.
- Added node.destroySubscription(subscription) to each test callback following publisher.kill('SIGINT') to ensure a clean test environment.
- Improves test reliability by explicitly cleaning up subscriptions in all message type tests.
Fix: #1170
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses the flakiness of test-message-type.js by ensuring that subscriptions are properly destroyed after each test execution.
Fix: #1170