Support to resolve topic/service name #1175
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This pull request introduces support for resolving topic and service names with remapping and expansion functionality. Key changes include:
- Addition of new tests in both TypeScript and JavaScript to verify the resolution behavior.
- Implementation of a new C++ binding function (ResolveName) to expose the name resolution logic.
- Updates to the Node class in JavaScript to provide resolveTopicName and resolveServiceName methods.
Reviewed Changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| test/types/index.test-d.ts | Added test expectations for resolved topic and service names |
| test/test-node.js | Added test cases for topic and service name resolution |
| src/rcl_node_bindings.cpp | Introduced the ResolveName function, binding C++ resolution API |
| lib/node.js | Implemented resolveTopicName and resolveServiceName methods |
Comments suppressed due to low confidence (1)
lib/node.js:1719
- [nitpick] Consider renaming the parameter 'service' to 'serviceName' for improved clarity in the documentation and code readability.
resolveServiceName(service, onlyExpand = false) {
minggangw
added a commit
that referenced
this pull request
Jun 23, 2025
This pull request introduces support for resolving topic and service names with remapping and expansion functionality. Key changes include: - Addition of new tests in both TypeScript and JavaScript to verify the resolution behavior. - Implementation of a new C++ binding function (ResolveName) to expose the name resolution logic. - Updates to the Node class in JavaScript to provide resolveTopicName and resolveServiceName methods. Fix: #1174
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces support for resolving topic and service names with remapping and expansion functionality. Key changes include:
Fix: #1174