Correct the parameter type of ActionServer constructor #1210
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR corrects the parameter type of the ActionServer constructor by adding a missing goalCallback parameter to properly match the expected type signature.
- Added
goalCallbackparameter to ActionServer constructor call - Implemented the
goalCallbackfunction with proper type annotations
| 'fibonacci', | ||
| executeCallback | ||
| executeCallback, | ||
| goalCallback |
There was a problem hiding this comment.
[nitpick] The goalCallback parameter is being passed to the ActionServer constructor but is defined after its usage. Consider moving the goalCallback function definition before the ActionServer instantiation to improve code readability and follow the pattern used with executeCallback.
minggangw
added a commit
that referenced
this pull request
Jul 31, 2025
This PR corrects the parameter type of the ActionServer constructor by adding a missing `goalCallback` parameter to properly match the expected type signature. - Added `goalCallback` parameter to ActionServer constructor call - Implemented the `goalCallback` function with proper type annotations Fix: #1209
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR corrects the parameter type of the ActionServer constructor by adding a missing
goalCallbackparameter to properly match the expected type signature.goalCallbackparameter to ActionServer constructor callgoalCallbackfunction with proper type annotationsFix: #1209