Remove automated.py #1249
Merged
Remove automated.py #1249
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR removes the entire benchmark/automated.py file, which appears to be a comprehensive benchmarking script for ROS2 performance testing across different language implementations (C++, Node.js, and Python).
- Removes a 1,077-line Python script used for automated benchmarking
- Eliminates functionality for testing ROS2 subscription/publisher and service/client patterns
- Removes performance monitoring capabilities for CPU and memory usage across different ROS2 language bindings
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
minggangw
added a commit
that referenced
this pull request
Sep 10, 2025
This PR removes the entire `benchmark/automated.py` file, which appears to be a comprehensive benchmarking script for ROS2 performance testing across different language implementations (C++, Node.js, and Python). Fix: #1248
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the entire
benchmark/automated.pyfile, which appears to be a comprehensive benchmarking script for ROS2 performance testing across different language implementations (C++, Node.js, and Python).Fix: #1248