Remove SlowBuffer from ref #1313
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR removes deprecated SlowBuffer support from the ref-napi library. SlowBuffer was deprecated in Node.js v6.0.0 and removed in later versions, making this legacy compatibility code unnecessary for modern Node.js versions.
Key Changes:
- Removed the
SlowBufferprototype extension block that copied Buffer methods to SlowBuffer - Eliminated the conditional check for whether
SlowBufferinherits fromBuffer
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
minggangw
added a commit
that referenced
this pull request
Oct 30, 2025
This PR removes deprecated `SlowBuffer` support from the ref-napi library. `SlowBuffer` was deprecated in Node.js v6.0.0 and removed in later versions, making this legacy compatibility code unnecessary for modern Node.js versions. **Key Changes:** - Removed the `SlowBuffer` prototype extension block that copied Buffer methods to SlowBuffer - Eliminated the conditional check for whether `SlowBuffer` inherits from `Buffer` Fix: #1312
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes deprecated
SlowBuffersupport from the ref-napi library.SlowBufferwas deprecated in Node.js v6.0.0 and removed in later versions, making this legacy compatibility code unnecessary for modern Node.js versions.Key Changes:
SlowBufferprototype extension block that copied Buffer methods to SlowBufferSlowBufferinherits fromBufferFix: #1312