@@ -97,9 +97,6 @@ def test_advertise_action(self):
9797 )
9898 self .advertise .advertise_action (advertise_msg )
9999
100- @unittest .skip (
101- reason = "Currently fails in Iron due to https://github.com/ros2/rclpy/issues/1195. Unskip when Iron is EOL in Nov 2024."
102- )
103100 def test_execute_advertised_action (self ):
104101 # Advertise the action
105102 action_path = "/fibonacci_action_2"
@@ -209,9 +206,6 @@ def test_execute_advertised_action(self):
209206 self .assertEqual (self .received_message ["values" ]["sequence" ], [0 , 1 , 1 , 2 , 3 , 5 ])
210207 self .assertEqual (self .received_message ["status" ], GoalStatus .STATUS_SUCCEEDED )
211208
212- @unittest .skip (
213- reason = "Currently fails in due to https://github.com/ros2/rclpy/issues/1195, need to fix this"
214- )
215209 def test_cancel_advertised_action (self ):
216210 # Advertise the action
217211 action_path = "/fibonacci_action_3"
@@ -302,7 +296,6 @@ def test_cancel_advertised_action(self):
302296 self .assertEqual (self .received_message ["values" ]["sequence" ], [])
303297 self .assertEqual (self .received_message ["status" ], GoalStatus .STATUS_CANCELED )
304298
305- @unittest .skip ("Currently raises an exception not catchable by unittest, need to fix this" )
306299 def test_unadvertise_action (self ):
307300 # Advertise the action
308301 action_path = "/fibonacci_action_4"
@@ -346,8 +339,6 @@ def test_unadvertise_action(self):
346339 self .assertTrue ("id" in self .received_message )
347340
348341 # Now unadvertise the action
349- # TODO: This raises an exception, likely because of the following rclpy issue:
350- # https://github.com/ros2/rclpy/issues/1098
351342 unadvertise_msg = loads (dumps ({"op" : "unadvertise_action" , "action" : action_path }))
352343 self .received_message = None
353344 self .unadvertise .unadvertise_action (unadvertise_msg )
0 commit comments