Skip to content

Commit 8cd4208

Browse files
authored
Add warnings about default parameter values changes (#997)
* Add warning about `call_services_in_new_thread` parameter * Fix flake8 error * Add warning about `send_action_goals_in_new_thread` parameter
1 parent dfc412c commit 8cd4208

File tree

1 file changed

+16
-0
lines changed

1 file changed

+16
-0
lines changed

rosbridge_server/scripts/rosbridge_websocket.py

Lines changed: 16 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -341,6 +341,22 @@ def check_deprecated_parameters(self):
341341
"will be updated to 5.0 seconds."
342342
)
343343

344+
if RosbridgeWebSocket.call_services_in_new_thread is False:
345+
self.get_logger().warn(
346+
"The 'call_services_in_new_thread' parameter is currently set to False, "
347+
"which means service calls will block the main thread. "
348+
"Please note that in the Jazzy and later releases, the default value for this parameter "
349+
"will be updated to True."
350+
)
351+
352+
if RosbridgeWebSocket.send_action_goals_in_new_thread is False:
353+
self.get_logger().warn(
354+
"The 'send_action_goals_in_new_thread' parameter is currently set to False, "
355+
"which means sending action goals will block the main thread. "
356+
"Please note that in the Jazzy and later releases, the default value for this parameter "
357+
"will be updated to True."
358+
)
359+
344360

345361
def main(args=None):
346362
if args is None:

0 commit comments

Comments
 (0)