chore: Use ruff to replace other linters used in pre-commit hook (#1062)

* chore: Use ruff to replace other linters used in pre-commit hook (backport #1058)

* Add bandit checks to ruff

* Replace flake8 with ruff

* Add isort check to ruff

* Autofix ruff lint errors

* Set line-length to 100

* Replace black with ruff format

* Reformat with ruff

* Move ruff and codespell config to pyproject.toml

* Retain black configuration

* Move codespell configuration back to setup.cfg

* Format code before linting it in pre-commit

* Enable more ruff lint rules

* Fix isort problems

Author: bjsowa

.pre-commit-config.yaml

@@ -15,27 +15,6 @@ repos:
       - id: mixed-line-ending
       - id: trailing-whitespace
 
-  - repo: https://github.com/pycqa/isort
-    rev: 5.13.2
-    hooks:
-      - id: isort
-
-  - repo: https://github.com/psf/black
-    rev: 24.8.0
-    hooks:
-      - id: black
-
-  - repo: https://github.com/PyCQA/flake8
-    rev: 7.1.1
-    hooks:
-      - id: flake8
-
-  - repo: https://github.com/PyCQA/bandit
-    rev: 1.7.10
-    hooks:
-      - id: bandit
-        args: ["--skip", "B101,B110,B311"]
-
   - repo: https://github.com/codespell-project/codespell
     rev: v2.3.0
     hooks:
@@ -44,4 +23,5 @@ repos:
   - repo: https://github.com/astral-sh/ruff-pre-commit
     rev: v0.12.7
     hooks:
+      - id: ruff-format
       - id: ruff-check

pyproject.toml

@@ -1,5 +1,96 @@
-[tool.bandit]
-skips = ["B101", "B110", "B311"]
-
 [tool.black]
+# We use ruff for formatting, but black formatter should be compatible with ruff.
+line-length = 100
+
+[tool.ruff]
 line-length = 100
+
+[tool.ruff.lint]
+select = [
+    # "AIR", # Airflow
+    # "ERA", # Eradicate
+    # "FAST", # FastAPI
+
+    # flake8 extensions
+    "YTT", # flake8-2020
+    # "ANN", # flake8-annotations
+    "ASYNC", # flake8-async
+    "S", # flake8-bandit
+    # "BLE", # flake8-blind-except
+    # "FBT", # flake8-boolean-trap
+    # "B", # flake8-bugbear
+    # "A", # flake8-builtins
+    # "COM", # flake8-commas
+    "C4", # flake8-comprehensions
+    # "CPY", # flake8-copyright
+    # "DTZ", # flake8-datetimez
+    "T10", # flake8-debugger
+    # "DJ", # flake8-django
+    # "EM", # flake8-errmsg
+    # "EXE", # flake8-executable
+    # "FIX", # flake8-fixme
+    # "FA", # flake8-future-annotations
+    "INT", # flake8-gettext
+    # "ISC", # flake8-implicit-str-concat
+    "ICN", # flake8-import-conventions
+    # "LOG", # flake8-logging
+    # "G", # flake8-logging-format
+    # "INP", # flake8-no-pep420
+    # "PIE", # flake8-pie
+    # "T20", # flake8-print
+    # "PYI", # flake8-pyi
+    # "PT", # flake8-pytest-style
+    "Q", # flake8-quotes
+    # "RSE", # flake8-raise
+    # "RET", # flake8-return
+    # "SLF", # flake8-self
+    # "SIM", # flake8-simplify
+    "SLOT", # flake8-slots
+    "TID", # flake8-tidy-imports
+    # "TD", # flake8-todos
+    # "TC", # flake8-type-checking
+    # "ARG", # flake8-unused-arguments
+    # "PTH", # flake8-use-pathlib
+
+    "FLY", # flynt
+    "I", # isort
+    "C90", # mccabe
+    "NPY", # numpy
+    "PD", # pandas-vet
+    # "N", # pep8-naming
+    # "PERF", # Perflint
+    "E", # pycodestyle errors
+    "W", # pycodestyle warnings
+    # "DOC", # pydoclint
+    "D", # pydocstyle
+    "F", # pyflakes
+    "PGH", # pygrep-hooks
+    # "PL", # pylint
+    # "UP", # pyupgrade
+    # "FURB", # refurb
+    # "RUF", # ruff
+    # "TRY", # tryceratops
+]
+ignore = [
+    # Undocumented code
+    "D100",
+    "D101",
+    "D102",
+    "D103",
+    "D104",
+    "D105",
+    "D106",
+    "D107",
+
+    # Conflicting pydocstyle rules
+    "D203", # incorrect-blank-line-before-class
+    "D212", # multi-line-summary-first-line
+
+    "S101", # assert
+    "S110", # try-except-pass
+    "S311", # suspicious-non-cryptographic-random-usage
+]
+
+mccabe.max-complexity = 36
+
+pycodestyle.max-line-length = 217

rosapi/scripts/rosapi_node

@@ -70,7 +70,6 @@ from rosapi_msgs.srv import (
 
 
 class Rosapi(Node):
-
     NAME = "rosapi"
 
     def __init__(self):

rosapi/src/rosapi/params.py

@@ -39,6 +39,7 @@
 from rcl_interfaces.srv import ListParameters
 from ros2node.api import get_absolute_node_name
 from ros2param.api import call_get_parameters, call_set_parameters, get_parameter_value
+
 from rosapi.proxy import get_nodes
 
 """ Methods to interact with the param server.  Values have to be passed

rosbridge_library/src/rosbridge_library/capabilities/action_feedback.py

@@ -36,7 +36,6 @@
 
 
 class ActionFeedback(Capability):
-
     action_feedback_msg_fields = [
         (True, "action", str),
         (False, "id", str),

rosbridge_library/src/rosbridge_library/capabilities/action_result.py

@@ -36,7 +36,6 @@
 
 
 class ActionResult(Capability):
-
     action_result_msg_fields = [
         (True, "action", str),
         (False, "id", str),

rosbridge_library/src/rosbridge_library/capabilities/advertise.py

@@ -80,7 +80,6 @@ def is_empty(self):
 
 
 class Advertise(Capability):
-
     advertise_msg_fields = [(True, "topic", str), (True, "type", str)]
     unadvertise_msg_fields = [(True, "topic", str)]
 

rosbridge_library/src/rosbridge_library/capabilities/advertise_action.py

@@ -38,14 +38,14 @@
 from rclpy.action import ActionServer
 from rclpy.action.server import CancelResponse, ServerGoalHandle
 from rclpy.callback_groups import ReentrantCallbackGroup
+
 from rosbridge_library.capability import Capability
 from rosbridge_library.internal import message_conversion
 from rosbridge_library.internal.ros_loader import get_action_class
 from rosbridge_library.protocol import Protocol
 
 
 class AdvertisedActionHandler:
-
     id_counter = 1
 
     def __init__(

rosbridge_library/src/rosbridge_library/capabilities/advertise_service.py

@@ -2,13 +2,13 @@
 
 import rclpy
 from rclpy.callback_groups import ReentrantCallbackGroup
+
 from rosbridge_library.capability import Capability
 from rosbridge_library.internal import message_conversion
 from rosbridge_library.internal.ros_loader import get_service_class
 
 
 class AdvertisedServiceHandler:
-
     id_counter = 1
 
     def __init__(self, service_name, service_type, protocol):

rosbridge_library/src/rosbridge_library/capabilities/call_service.py

@@ -39,7 +39,6 @@
 
 
 class CallService(Capability):
-
     call_service_msg_fields = [
         (True, "service", str),
         (False, "fragment_size", (int, type(None))),