Skip to content

Commit cc723b7

Browse files
committed
Add warning about possible service calls blocking indefinitely
1 parent 2aeec98 commit cc723b7

File tree

1 file changed

+10
-0
lines changed

1 file changed

+10
-0
lines changed

rosbridge_server/scripts/rosbridge_websocket.py

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -72,6 +72,7 @@ def __init__(self):
7272
##################################################
7373

7474
self.protocol_parameter_handling()
75+
self.check_deprecated_parameters()
7576

7677
# get tornado application parameters
7778
tornado_settings = {}
@@ -331,6 +332,15 @@ def protocol_parameter_handling(self):
331332
UnadvertiseService.services_glob = RosbridgeWebSocket.services_glob
332333
CallService.services_glob = RosbridgeWebSocket.services_glob
333334

335+
def check_deprecated_parameters(self):
336+
if RosbridgeWebSocket.default_call_service_timeout == 0.0:
337+
self.get_logger().warn(
338+
"The 'default_call_service_timeout' parameter is currently set to 0.0, "
339+
"which means service calls will block indefinitely if no response is received. "
340+
"Please note that in the Jazzy and later releases, the default value for this parameter "
341+
"will be updated to 5.0 seconds."
342+
)
343+
334344

335345
def main(args=None):
336346
if args is None:

0 commit comments

Comments
 (0)