Skip to content

Commit fb157a0

Browse files
electronicofiveJuan David Vergara
andauthored
fix: Correct JSON serialization in PNG compression and update tests (#1044)
Co-authored-by: Juan David Vergara <[email protected]>
1 parent f3baaf2 commit fb157a0

File tree

2 files changed

+3
-2
lines changed

2 files changed

+3
-2
lines changed

rosbridge_library/src/rosbridge_library/internal/pngcompression.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ def encode(string):
4949
buff = BytesIO()
5050
i.save(buff, "png")
5151
encoded = standard_b64encode(buff.getvalue())
52-
return encoded
52+
return encoded.decode()
5353

5454

5555
def decode(string):

rosbridge_library/test/internal/test_compression.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,10 +10,11 @@ def test_compress(self):
1010
string = str(bytearray(bytes_data))
1111
encoded = pngcompression.encode(string)
1212
self.assertNotEqual(string, encoded)
13+
self.assertIsInstance(encoded, str)
1314

1415
def test_compress_decompress(self):
1516
bytes_data = list(range(128)) * 10000
16-
string = str(bytes(bytes_data))
17+
string = str(bytearray(bytes_data))
1718
encoded = pngcompression.encode(string)
1819
self.assertNotEqual(string, encoded)
1920
decoded = pngcompression.decode(encoded)

0 commit comments

Comments
 (0)