Skip to content

Conversation

@EzraBrooks
Copy link
Collaborator

@EzraBrooks EzraBrooks commented Nov 12, 2025

Public API Changes

None

Description

We have at least one passionate user (because they contributed!) using Bun, so there's probably others. Bun and Deno can run .ts files directly - but if we confuse them with import paths that don't resolve until after a transpile step, they can break.

This PR ensures all files are imported as .ts files for compatibility with TypeScript runtimes and then rewritten at build time for compatibility with traditional JavaScript runtimes.

Copy link
Collaborator Author

@EzraBrooks EzraBrooks Nov 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

jeez, 2000 lines added to package-lock. eslint-plugin-import has so many dependencies. good thing it's a dev dependency and won't ship to users.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do want this package for other reasons too, though, so it's a price I'm willing to pay.

@EzraBrooks EzraBrooks force-pushed the ensure-runnable-with-bun-etc branch 3 times, most recently from c967146 to ca46d64 Compare November 14, 2025 17:53
@EzraBrooks EzraBrooks marked this pull request as ready for review November 14, 2025 17:53
We have at least one passionate user (because they contributed!) using Bun,
so there's probably others. Bun and Deno can run .ts files directly - but
if we confuse them with import paths that don't resolve until after a transpile
step, they can break.

This PR ensures all files are imported as .ts files and then rewritten at build time
for compatibility with non-TypeScript runtimes.
@EzraBrooks EzraBrooks force-pushed the ensure-runnable-with-bun-etc branch from ca46d64 to 0cba1d2 Compare November 17, 2025 15:39
@EzraBrooks EzraBrooks merged commit cb869b9 into develop Nov 17, 2025
14 checks passed
@EzraBrooks EzraBrooks deleted the ensure-runnable-with-bun-etc branch November 17, 2025 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants