Skip to content

Enable noImplicitAny #1066

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
EzraBrooks merged 2 commits into from
Nov 13, 2025
Merged

Enable noImplicitAny #1066

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d50b913
Enable `noImplicitAny`
EzraBrooks Nov 13, 2025
860e89b
Set `strict: true` and remove implied rules
EzraBrooks Nov 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/core/Ros.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,10 @@ import type {
} from "./transport/Transport.js";
import { WebSocketTransportFactory } from "./transport/WebSocketTransportFactory.ts";

interface TypeDefDict {
[key: string]: string | string[] | TypeDefDict | TypeDefDict[];
}
Comment on lines +36 to +38
Copy link
Collaborator Author

@EzraBrooks EzraBrooks Nov 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

literally wtf is this type lmao


/**
* Manages connection to the rosbridge server and all interactions with ROS.
*
Expand Down Expand Up @@ -641,7 +645,7 @@ export default class Ros extends EventEmitter<
hints: rosapi.TypeDef[],
) => {
// calls itself recursively to resolve type definition using hints.
const typeDefDict = {};
const typeDefDict: TypeDefDict = {};
for (let i = 0; i < theType.fieldnames.length; i++) {
const arrayLen = theType.fieldarraylen[i];
const fieldName = theType.fieldnames[i];
Expand Down
2 changes: 1 addition & 1 deletion tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@

/* Rules to be enabled */
"exactOptionalPropertyTypes": false /* Differentiate between undefined and not present when type checking */,
"noImplicitAny": false /* Enable error reporting for expressions and declarations with an implied 'any' type. */,
Copy link
Member

@bjsowa bjsowa Nov 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should probably move it to the enabled section but if your next PR is to just replace every rule with strict: true then it doesn't really matter.

Copy link
Collaborator Author

@EzraBrooks EzraBrooks Nov 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep, one sec, I realized this and also that as of this PR we can set strict: true and remove a bunch of these explicit settings

"noImplicitAny": true /* Enable error reporting for expressions and declarations with an implied 'any' type. */,

"types": ["@types/node"]
},
Expand Down