Export Rosbridge protocol types #1067
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mers when creating their custom transports
EzraBrooks
reviewed
Nov 14, 2025
Collaborator
EzraBrooks
left a comment
EzraBrooks
left a comment
There was a problem hiding this comment.
Thanks! However I think this actually might be too much detail - a lot of these APIs aren't exposed at the edge. Let me break apart my earlier PR to expose our edge API types to satisfy this issue
Collaborator
|
Alternatively, so we don't have to wait for review from other maintainers, you could change this PR to do part of what my earlier PR does - enable failing on warnings in typedoc - and just expose all the missing APIs instead of trying to refactor some out like I did! |
Collaborator
|
superseded by #1073 |
Contributor
Author
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Public API Changes
Makes available the rosbridge protocol types.
Description
With the introduction of transports in #1060, library consumers may want to implement their own transports. When implementing the
ITransportinterface, thesendandon('message')methods use theRosbridgeMessagetype.However, currently developers can't import or reference that type because it's not technically exported.