Switch from cbor-js to cbor2 #1096
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EzraBrooks
force-pushed
the
switch-from-cbor-js-to-cbor2
branch
from
07b2ec5 to
1d6bfe4
Compare
EzraBrooks
commented
Nov 17, 2025
| */ | ||
| private handleCborMessage(cbor: ArrayBuffer) { | ||
| const data: unknown = CBOR.decode(cbor, typedArrayTagger); | ||
| const data: unknown = decode(new Uint8Array(cbor)); |
Collaborator
Author
There was a problem hiding this comment.
Uint8Arrays are views on ArrayBuffers, so this (thankfully) doesn't do any copying of potentially large data.
Contributor
|
@EzraBrooks Feel free to pull from #926 for this if it'll make it easier, I had a commit in there to replace all the cbor stuff even though it didn't end up making it in. |
Collaborator
Author
|
Thanks Drew! I think this is good to go already, I wished I'd remembered to look at where you'd done it |
Collaborator
Author
MatthijsBurgh
approved these changes
Nov 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Public API Changes
64-bit integers will now properly be represented as BigInts.
Description
Closes #1095. I was hoping to leave this be, but it's being annoying while I'm testing pure-ESM use cases for roslibjs. At least it deletes a bunch of code and fixes the loss-of-precision issue we used to warn about when using CBOR.