Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/core/Ros.ts
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@ export default class Ros extends EventEmitter<
}
}

public isConnected(): boolean {
public get isConnected(): boolean {
return this.#isConnected;
}

Expand Down Expand Up @@ -188,7 +188,7 @@ export default class Ros extends EventEmitter<
* If not connected, queues the message to send once reconnected.
*/
public callOnConnection(message: RosbridgeMessage) {
if (this.isConnected()) {
if (this.isConnected) {
this.transport?.send(message);
} else {
this.once("connection", () => {
Expand Down
10 changes: 5 additions & 5 deletions test/ros.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -165,7 +165,7 @@ describe("Ros", function () {
transportFactory: mockTransportFactory,
});

expect(ros.isConnected()).toBe(false);
expect(ros.isConnected).toBe(false);
});

it("returns true when connected", async () => {
Expand All @@ -176,7 +176,7 @@ describe("Ros", function () {
await ros.connect(mockRosUrl);
publishMockTransportEvent("open", new Event("open"));

expect(ros.isConnected()).toBe(true);
expect(ros.isConnected).toBe(true);
});

it("returns false when disconnected", async () => {
Expand All @@ -188,7 +188,7 @@ describe("Ros", function () {

mockTransport.close();

expect(ros.isConnected()).toBe(false);
expect(ros.isConnected).toBe(false);
});
});

Expand All @@ -204,7 +204,7 @@ describe("Ros", function () {
ros.close();

expect(mockTransport.close).toHaveBeenCalled();
expect(ros.isConnected()).toBe(false);
expect(ros.isConnected).toBe(false);
});

it("does not close the transport if it is already closed", () => {
Expand All @@ -215,7 +215,7 @@ describe("Ros", function () {
ros.close();

expect(mockTransport.close).not.toHaveBeenCalled();
expect(ros.isConnected()).toBe(false);
expect(ros.isConnected).toBe(false);
});
});

Expand Down
2 changes: 1 addition & 1 deletion test/setup/ros-backend.ts
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ async function waitForRosConnection(ros: Ros, timeout = 5000) {
});

// If already connected
if (ros.isConnected()) {
if (ros.isConnected) {
clearTimeout(timeoutId);
resolve();
}
Expand Down
Loading