Move examples to their own package #1110
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EzraBrooks
commented
Nov 20, 2025
| "http-server": "^14.1.1" | ||
| }, | ||
| "dependencies": { | ||
| "roslib": "^2.0.0" |
Collaborator
Author
There was a problem hiding this comment.
roslib will automatically be symlinked from the other directory because it's in the same workspace, this specification only affects the distributed package (if we distribute this package)
bjsowa
approved these changes
Nov 20, 2025
bjsowa
reviewed
Nov 20, 2025
| ## Packages | ||
|
|
||
| - [roslibjs](./packages/roslib/README.md) | ||
| - [roslibjs examples](./packages/roslib-examples/README.md) |
Member
There was a problem hiding this comment.
This confuses me. Is it roslib or roslibjs ? Where does the difference come from?
Collaborator
Author
There was a problem hiding this comment.
The package is actually called roslib, I guess because historically the "JS" part was redundant because it was the only roslib and it was being published as a javascript package?
We can decide to change the name later when we eventually adopt an organization namespace on NPM since that will require changing the name anyway
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
step 1 of #1062. working on figuring out how to make the rosbridge test container launcher portable to this package and others so I can deduplicate the example tests.