-
Notifications
You must be signed in to change notification settings - Fork 405
fix compile error #895
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
fix compile error #895
Changes from 9 commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
2575db7
fix compile error
Yancey2023 68bc966
update versions of dependency
Yancey2023 63ed728
update dependencies
Yancey2023 c456ab1
update dependencies
Yancey2023 37f6ba2
only bump dependencies of which the older version is not working anymore
Yancey2023 66d34d9
Merge branch 'develop' into develop
MatthijsBurgh 054983b
Merge remote-tracking branch 'upstream/develop' into develop
Yancey2023 cce442d
adapt to new verion of xmldom
Yancey2023 0c4e456
Merge remote-tracking branch 'upstream/develop' into develop
Yancey2023 55ff6db
add new line at EOF
Yancey2023 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -33,7 +33,7 @@ | |
"vitest": "^3.0.2" | ||
}, | ||
"dependencies": { | ||
"@xmldom/xmldom": "^0.9.0", | ||
"@xmldom/xmldom": "^0.9.8", | ||
"cbor-js": "^0.1.0", | ||
"eventemitter3": "^5.0.1", | ||
"pngparse": "^2.0.0", | ||
|
@@ -70,4 +70,4 @@ | |
], | ||
"types": "dist/RosLib.d.ts", | ||
"author": "Robot Webtools Team <[email protected]> (https://robotwebtools.github.io)" | ||
} | ||
} | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -4,7 +4,7 @@ | |
* @author Russell Toris - [email protected] | ||
*/ | ||
|
||
import { DOMParser, MIME_TYPE } from '@xmldom/xmldom'; | ||
import { DOMParser, Element, MIME_TYPE } from '@xmldom/xmldom'; | ||
import UrdfMaterial from './UrdfMaterial.js'; | ||
import UrdfLink from './UrdfLink.js'; | ||
import UrdfJoint from './UrdfJoint.js'; | ||
|
@@ -18,7 +18,7 @@ export interface UrdfModelOptions { | |
/** | ||
* The XML element to parse. | ||
*/ | ||
xml?: Element; | ||
xml: Element | null; | ||
/** | ||
* The XML element to parse as a string. | ||
*/ | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,5 @@ | ||
import { Element } from '@xmldom/xmldom'; | ||
|
||
export enum UrdfType { | ||
SPHERE = 0, | ||
BOX = 1, | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -4,6 +4,7 @@ | |
* @author Russell Toris - [email protected] | ||
*/ | ||
|
||
import { Element } from '@xmldom/xmldom'; | ||
import Pose from '../math/Pose.js'; | ||
import UrdfCylinder from './UrdfCylinder.js'; | ||
import UrdfBox from './UrdfBox.js'; | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix the missing newline at EOF
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
got it