Skip to content

Fixed linting errors #959

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 20, 2025
+5 −5
Merged

Fixed linting errors #959

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/urdf/UrdfBox.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ export default class UrdfBox {

// Parse the xml string
const size: Optional<string[]> = xml.getAttribute(UrdfAttrs.Size)?.split(' ');
if (!size || size.length !== 3) {
if (size?.length !== 3) {
return;
}

Expand Down
2 changes: 1 addition & 1 deletion src/urdf/UrdfColor.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ export default class UrdfColor {
constructor({ xml }: UrdfDefaultOptions) {
// Parse the xml string
const rgba: Optional<string[]> = xml.getAttribute(UrdfAttrs.Rgba)?.split(' ');
if (!rgba || rgba.length !== 4) {
if (rgba?.length !== 4) {
return;
}

Expand Down
2 changes: 1 addition & 1 deletion src/urdf/UrdfMesh.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ export default class UrdfMesh {

// Check for a scale
const scale: Optional<string[]> = xml.getAttribute(UrdfAttrs.Scale)?.split(' ');
if (!scale || scale.length !== 3) {
if (scale?.length !== 3) {
return;
}

Expand Down
4 changes: 2 additions & 2 deletions src/urdf/UrdfUtils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ export function parseUrdfOrigin(originElement: Element): Pose {
// Check the XYZ
const xyz: string[] | undefined = originElement.getAttribute(UrdfAttrs.Xyz)?.split(' ');
let position: Vector3 = new Vector3();
if (xyz && xyz.length === 3) {
if (xyz?.length === 3) {
position = new Vector3({
x: parseFloat(xyz[0]),
y: parseFloat(xyz[1]),
Expand All @@ -18,7 +18,7 @@ export function parseUrdfOrigin(originElement: Element): Pose {
// Check the RPY
const rpy = originElement.getAttribute(UrdfAttrs.Rpy)?.split(' ');
let orientation = new Quaternion();
if (rpy && rpy.length === 3) {
if (rpy?.length === 3) {
// Convert from RPY
const roll = parseFloat(rpy[0]);
const pitch = parseFloat(rpy[1]);
Expand Down